Closed
Bug 1075232
Opened 10 years ago
Closed 10 years ago
Record which suggestion of the search screen was tapped in telemetry
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox33 wontfix, firefox34 fixed, firefox35 fixed)
RESOLVED
FIXED
Firefox 35
People
(Reporter: antlam, Assigned: Margaret)
Details
Attachments
(2 files)
94.00 KB,
image/png
|
Details | |
2.56 KB,
patch
|
mfinkle
:
review+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Similar to bug 1068739 But, since the UI is quite different in Firefox, it'd be nice to know this too. Also note, only the default gets placed above frecency results in this case. There might be some interesting numbers here that we could use to improve this UX too.
Flags: needinfo?(mark.finkle)
Comment 1•10 years ago
|
||
Just so we have some defined terms, I'm attaching an image with the search suggestions labelled: A = Just what the user typed. Not really a suggestion. UI Telemetry: "user" B = Engine provide suggestion that is also a valid URL. UI Telemetry: "url" C = Engine provide suggestion. UI Telemetry: "engine" What additional data would you like saved?
Flags: needinfo?(mark.finkle)
Reporter | ||
Comment 2•10 years ago
|
||
Perfect, can we also get Engine 0's A, Engine 1's A, Engine 2's A, Engine 3's A, etc?
Flags: needinfo?(mark.finkle)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → margaret.leibovic
Assignee | ||
Comment 3•10 years ago
|
||
This just replaces "engine" with "engine.1", "engine.2", etc. depending on which engine suggestion was tapped.
Attachment #8499585 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #8499585 -
Flags: review?(mark.finkle) → review+
Flags: needinfo?(mark.finkle)
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to :Margaret Leibovic from comment #3) > Created attachment 8499585 [details] [diff] [review] > Record position of search suggestion that was tapped in telemetry > > This just replaces "engine" with "engine.1", "engine.2", etc. depending on > which engine suggestion was tapped. Awesome!
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d1094a154b41
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d1094a154b41
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment 7•10 years ago
|
||
Comment on attachment 8499585 [details] [diff] [review] Record position of search suggestion that was tapped in telemetry Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: Useful telemetry [Describe test coverage new/current, TBPL]: [Risks and why]: low risk, small patch [String/UUID change made/needed]: none
Attachment #8499585 -
Flags: approval-mozilla-beta?
Updated•10 years ago
|
Comment 8•10 years ago
|
||
Comment on attachment 8499585 [details] [diff] [review] Record position of search suggestion that was tapped in telemetry Beta+
Attachment #8499585 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•