1075509 - Standalone UI for link clickers needs "call failed" audio notification

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

This is a follow up of bug 1000240. We need to play a specific sound when a call fails in the Loop conversation window.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Call failed notification sound.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Play a sound on failed call in Loop standalone.

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8504072 [details] [diff] [review]
Play a sound on failed call in Loop standalone.

Cacelling the review for now as work in bug 1065203 will introduce a reusable AudioMixin providing exactly what we want here.

Comment 4

[Romain Gauthier [:tOkeshu]]

Attachment: Bug 1075509: Standalone UI needs "call failed" sound

The patch uses the AudioMixin introduced by Bug 1065203.
The sound used is the one corresponding to failed calls (see Bug 1065203 for the sound file).

Comment 5

[Romain Gauthier [:tOkeshu]]

Attachment: Bug 1075509: Standalone UI needs "call failed" sound

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8512673 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Review of attachment 8512673 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the missing test added.

::: browser/components/loop/standalone/content/js/webapp.jsx
@@ +572,5 @@
>    var FailedConversationView = React.createClass({
> +    mixins: [sharedMixins.AudioMixin],
> +
> +    componentDidMount: function() {
> +      this.play("failure");

Don't we want a test for this?

Comment 7

[Romain Gauthier [:tOkeshu]]

Attachment: Bug 1075509: Standalone UI needs "call failed" sound

I added a test, as well as the corresponding sound file I forgot in the last patch :B

Comment 8

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8513526 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Review of attachment 8513526 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 9

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/f9e9a9e2afba

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f9e9a9e2afba

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/72635769caad

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8513526 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only

Comment 13

[Mark Banner (:standard8)]

Clearing in-testsuite requests for features that are being removed from Hello as part of te user journey work in bug 1209713.