10756 - logging every selection doesn't allow for property changes

Status: RESOLVED INCOMPLETE

(Core :: DOM: Editor, defect, P5)

Description

[Kathleen :Brade]

When logging, you can't replay the commands to change the style since they are
lost when the selection is reset.

For example, in an empty document log the following steps:
 * type:  abc
 * click the bold icon
 * type:  def

Notice that in the log, the selection is set between each keystroke and command.
This means that setting bold won't work since the editor thinks that the
selection has changed (so the bold command is ignored).

Comment 1

[kinmoz]

Accepting bug, setting milestone to M11.

Just wanted to note that you can replay style changes that are applied to
selected (hilighted) content. This bug happens when trying to apply a style when
the selection is a caret.

Comment 2

[kinmoz]

By the way, the temporary workaround for this is to edit the journal.js file and
comment out the calls to EditorSetSelectionFromOffset() before every call to
SetTextProperty.

Comment 3

[kinmoz]

Oops, screwed up on the workaround description above.

Comment out the call to EditorSetSelectionFromOffset() AFTER the call to
window.editorShell.SetTextProperty(), ONLY if the selection offsets for the
SetTextProperty() call match the selection offsets after it.

Comment 4

[kinmoz]

Moving some SpellChecker/TextServices feature requests and bugs, that can wait
till after beta 1, to milestone M14.

Comment 5

[kinmoz]

Moved to M15 to balance bug counts across milestones.

Comment 6

[kinmoz]

Moving all non-beta1 bugs to M16 since I am going on sabbatical.

Comment 7

[rubydoo123]

moving to m17

Comment 8

[kinmoz]

Move to M19.

Comment 9

[rubydoo123]

setting to future, although this was a great tool for QA to use for debugging

Comment 10

[rubydoo123]

adding help wanted keyword

Comment 11

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, untouched DOM/Storage bug's priority.

If you have reason to believe, this is wrong, please write a comment and ni :jstutte.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19c768547c7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10756 -  UI intermittent media playback failures (https://github.com/mozilla-mobile/fenix/pull/10775)

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

The original report was for the editor application, which is a very different scope from the current DOM:Editor. EditorSetSelectionFromOffset() is no longer in m-c.