1077129 - Dropdown for search filters is too long

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Connectivity: wifi
Gaia/device: flame/1.4


steps to reproduce:
1. launch marketplace-dev
2. Switch to New tab
3. Notice the dropdown


actual behavior:Dropdown is too long and looks ungainly. See screenshot

Comment 1

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/commit/0e405e5

Comment 2

[krupa raj[:krupa]]

I wouldn't call this resolved as yet. The temporary fix doesn't address all the issues. See http://cl.ly/image/371x1Y2a0l0z

Comment 3

[Philip [:pwalm]]

"show" and the dropdown should be aligned center to the screen, as a unit together. And the arrow in the dropdown is hard-aligned to the right of the drop down, there should be 20 px of padding to the right of it.

Comment 4

[Kevin Ngo [:ngoke]]

This had already been signed off upon: https://github.com/mozilla/fireplace/pull/675

The bug is to fix the centering of the option in the dropdown, not re-write the dropdown.

Comment 5

[Davor Spasovski [:spasovski]]

Dropdown looks centered to me: http://i.imgur.com/R54NMjJ.png