Closed
Bug 1078655
Opened 10 years ago
Closed 8 years ago
Tag parsing for .lang files should allow dash character
Categories
(www.mozilla.org :: L10N, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Unassigned)
Details
A tag like "contribute-2015" breaks completely the tag parsing for lang file (following tags are ignored). We should allow dashes in tags, even if we usually use underscores.
Updated•10 years ago
|
Mentor: pmac
Whiteboard: [good first bug]
Comment 1•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/0607768e187416bc398046912b7ba53bd4bb4967 Bug 1078655: update regex in dotlang parser to allow dashes https://github.com/mozilla/bedrock/commit/af8984f2aba722c458bf95e0320fa09fc181ae49 Merge pull request #2344 from pascalchevrel/bug-1078655-allow_dash_character_in_langfile_tags Bug 1078655: update regex in dotlang parser to allow dashes
Comment 2•10 years ago
|
||
Please check the "mentored" and whiteboard fields before working on a good first bug. We need bugs like this for contributor on-boarding and I continue to be unable to give them any because they're all taken by long-time contributors.
Updated•10 years ago
|
Mentor: pmac
Whiteboard: [good first bug]
Comment 3•10 years ago
|
||
I wrote the patch ans did the PR before you added the [good first bug] tag tout this bug.
Comment 4•10 years ago
|
||
Fair enough. We just need good-first-bugs. If you can help save some things like this for people who want to help I'd really appreciate it. Apologies for taking the bug comments off-topic.
Reporter | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•