1079641 - Make diffs more useful by sorting first

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

json stored in python dicts is not so great for consistent ordering, which makes diffs noisy.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [balrog] Sort the keys

This gets me a diff of
      "partials": {
        "Firefox-31.0-build2": "firefox-31.0-33.0.partial.mar", 
        "Firefox-32.0.2-build1": "firefox-32.0.2-33.0.partial.mar", 
-       "Firefox-32.0.3-build1": "firefox-32.0.3-33.0.partial.mar"
+       "Firefox-32.0.3-build1": "firefox-32.0.3-33.0.partial.mar", 
?                                                                 ++

+       "Firefox-33.0b9-build1": "firefox-33.0b9-33.0.partial.mar"
      }
    }, 
for fixing up the Firefox 33.0 blob (see https://wiki.mozilla.org/Releases/Firefox_33.0/BuildNotes#Updates_for_beta). It's still a little strange, but doesn't have any spurious changes in it for appVersion.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/d380eb2bd6d9bed46fd1247282703112be6173d3
Bug 1079641, make diffs more useful by sorting first, r=bhearsum

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Waiting for the next push to production. No great rush.

Comment 4

[[e-mail] (:bhearsum)]

I think this is in production now?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Oh yes, thanks for the reminder.