1079706 - [LockScreen] Encapsulate passcode pad as a standalone component (with LockScreenInputWindow)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Current LockScreenWindowManager and the old LockScreen manage the passpad directly. This increase the complication between sub-component and its parent. But things may not go well if we encapsulate it as a non-frame component and later we need to change it to use the real keyboard. So I prefer to make a LockScreenInputWindow that implement the interface of the near future InputWindow, so we can invoke real keyboard instead of the keypad and thus complete the encapsulation,  while in the future we don't need to rewrite the whole keypad logic again, but replace the implementation of LockScreenInputWindow to inherit the real InputWindow.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

After we implement the LockScreenInputWindow, we can evolute this with 3 steps:

1. LockScreenInputWindow + current keypad, not the real keyboard yet
2. LockScreenInputWindow + custom keyboard iframe, but not follow the real InputWindow flow
3. LockScreenInputWindow inherit the real InputWindow

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

The major risks: integration and Gaia UI tests.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8503874 [details] [review]
Patch

Set feedback since the patch now works. Left: tests and possible architecture issues.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Update the patch with what you commented. So I set the review.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8503874 [details] [review]
Patch

>https://github.com/mozilla-b2g/gaia/pull/24957

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8503874 [details] [review]
Patch

r=me

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Gaia-Try is green:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=9f209ebe8e7a

So I would land this patch. Hope In-Bound would keep good, too.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/b62cf59505bfb7eb2076be856827dcaff527c549