1079915 - Test for update of Trusted Hosted Apps

Status: RESOLVED WONTFIX

(Core Graveyard :: DOM: Apps, defect)

Description

[Zoran Jovanovic]

Attachment: Tests-for-update-of-Trusted-Hosted-Apps.patch

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 8501783 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch

Review of attachment 8501783 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I'm just holding on r+ until we can push that to try.

::: dom/apps/tests/test_trusted_app_install.js
@@ +68,4 @@
>      });
>    }
>  
> +  function updateApp(app) {

nit: rename to checkForUpdate() since this is what it's actually wrapping.

Comment 2

[Zoran Jovanovic]

Attachment: Tests-for-update-of-Trusted-Hosted-Apps.patch

- Fixed the latest comment from Fabrice (rename of function).
- Still waiting for try access.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8508726 [details] [diff] [review]
Tests-for-update-of-Trusted-Hosted-Apps.patch

Review of attachment 8508726 [details] [diff] [review]:
-----------------------------------------------------------------

Look fine, but we need a try build before landing.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Core Graveyard / DOM: Apps is inactive. Closing all bugs in this component.