1080360 - The lostpointercapture event on document when capturing element is removed

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Maksim Lebedev]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140825202822

Steps to reproduce:

Test assertion 11.3



Expected results:

If the pointer capture target override is removed from the document tree, clear the pending pointer capture target override and pointer capture target override nodes and fire a Pointer Event named lostpointercapture at the document.

Comment 1

[Maksim Lebedev]

Attachment: lostpc_on_document_ver1.diff

Add checking when lostpointercapture event should be fired at the Document

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8504031 [details] [diff] [review]
lostpc_on_document_ver1.diff

Why is this enough? The spec says we should clear the override states and 
dispatch the lostpointercapture event when an element is removed from document.
Couldn't we handle that case in EventStateManager::ContentRemoved?

We need some test here too.

Comment 3

[Maksim Lebedev]

(In reply to Olli Pettay [:smaug] from comment #2)
> Why is this enough? The spec says we should clear the override states and 
> dispatch the lostpointercapture event when an element is removed from document.
Specification says:
> If the pointer capture target override is removed from the document tree, ...
But I cannot see something like "When element is removed...".
I think that specification have no any pointer to time of firing lostpointercapture event.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

"If the pointer capture target override is removed from the document tree, clear the pending pointer capture target override and pointer capture target override nodes and fire a Pointer Event named lostpointercapture at the document."

Comment 5

[Maksim Lebedev]

Attachment: lostpc_on_document_ver2.diff

+ Changes: Explicity release pointer capture from removing content

(In reply to Olli Pettay [:smaug] from comment #2)
> Couldn't we handle that case in EventStateManager::ContentRemoved?
I think nsPresShell::ContentRemoved is more likely place for it

Comment 6

[Maksim Lebedev]

Attachment: lostpc_on_document_test_ver1.diff

+ Test for checking lostpointercapture event on document

Comment 7

[Maksim Lebedev]

Test without patch:
https://tbpl.mozilla.org/?tree=Try&rev=30fcc14b2c53
Test with patch:
https://tbpl.mozilla.org/?tree=Try&rev=5eb35323462d

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8506031 [details] [diff] [review]
lostpc_on_document_ver2.diff

>+  // We should check that aChild has not contain pointer capturing elements.
s/has not/does not/


>+  // In other case we should release pointer capture for this elements.
If it does we should release the pointer capture for the elements.


something like that.

Comment 9

[Maksim Lebedev]

Attachment: lostpc_on_document_ver3.diff

+ Changes comment according with comments

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8506723 [details] [diff] [review]
lostpc_on_document_ver3.diff

>+      if (nsIDocument* doc = aCaptureTarget->OwnerDoc()) {
>+        doc->DispatchEvent(event->InternalDOMEvent(), &dummy);
OwnerDoc() returns always a valid value.
So,
aCaptureTarget->OwnerDoc()->DispatchEvent(event->InternalDOMEvent(), &dummy);


r+

Comment 11

[Maksim Lebedev]

Attachment: lostpc_on_document_ver4.diff

+ Changes according with comments

Comment 12

[Maksim Lebedev]

If nobody have objections, I put checkin flag.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21e932e78181
https://hg.mozilla.org/integration/mozilla-inbound/rev/f45c1a2f0177

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21e932e78181
https://hg.mozilla.org/mozilla-central/rev/f45c1a2f0177