108109 - print header/footer "&PT" option uses English word "of"

Status: VERIFIED INVALID

(Core :: Printing: Output, defect)

Description

[don bright]

This is useless for people who don't speak english.

The problem, i believe, is here:
mozilla/layout/html/base/src/nsSimplePageSequence.cpp

737   // Doing this here so we only have to go get these formats once
738   SetPageNumberFormat("pagenumber",  "%1$d", PR_TRUE);
739   SetPageNumberFormat("pageofpages", "%1$d of %2$d", PR_FALSE);

Comment 1

[Kevin McCluskey (gone)]

Reassigning to Rod.

Comment 2

[rods (gone)]

Please that these are merely default values if localiztion is found. Look at the 
method itself where the strings are localized:

// Helper Function
void 
nsSimplePageSequenceFrame::SetPageNumberFormat(const char* aPropName, const 
char* aDefPropVal, PRBool aPageNumOnly)
{
  // Doing this here so we only have to go get these formats once
  nsAutoString pageNumberFormat;
  // Now go get the Localized Page Formating String
  nsAutoString propName;
  propName.AssignWithConversion(aPropName);
  PRUnichar* uPropName = ToNewUnicode(propName);
  if (uPropName != nsnull) {
    nsresult rv = nsFormControlHelper::GetLocalizedString(PRINTING_PROPERTIES, 
uPropName, pageNumberFormat);
    if (NS_FAILED(rv)) { // back stop formatting
      pageNumberFormat.AssignWithConversion(aDefPropVal);
    }
    nsMemory::Free(uPropName);
  }
  // Sets the format into a static data memeber which will own the memory and 
free it
  PRUnichar* uStr = ToNewUnicode(pageNumberFormat);
  if (uStr != nsnull) {
    SetPageNumberFormat(uStr, aPageNumOnly); // nsPageFrame will own the memory
  }

}

This bug is invalid

Comment 3

[sujay]

verified.