1081286 - WebGL2: account for the fact that SRGB formats break the 1:1 mapping between sized formats and (unsized format, type) pairs

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fix-srgb

This is a big difference between WebGL 1 + EXT_sRGB, and WebGL2.

The unsized format for SRGB formats is standard RGB/RGBA in WebGL2, whereas WebGL1 + EXT_sRGB had custom SRGB and SRGB_ALPHA constants for that.

I see that mostly as a quirk of the image-specification API and would rather not break the 1:1 nature of the table we use internally. Rather, it's an exception to ordinary image-specification validation rules.

This unearthed an issue with ValidateTexImage: it wasn't clear whether its internalFormat parameter was sized or unsized. That depended on the 'func' parameter. With this patch, it's now unambiguously sized, and this function internally queries the unsized format value when it needs to.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Fixed the WebGL conformance test for this. The patch here is what it takes to pass the fixed conformance test.

https://github.com/KhronosGroup/WebGL/pull/745

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a8131f0909f0

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27fdae08d9d8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27fdae08d9d8