1081397 - Declare lots of effectively-final fields as final.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Kitching [:ckitching]]

Because why not?

Comment 1

[Chris Kitching [:ckitching]]

Attachment: Finalise large numbers of fields

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8503489 [details] [diff] [review]
Finalise large numbers of fields

Review of attachment 8503489 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me.

Don't forget to upstream.

If this lands before 35 merges, I'll be happy -- makes it easier to uplift patches from 36.

::: mobile/android/base/gfx/Axis.java
@@ +129,5 @@
>      private float mFirstTouchPos;           /* Position of the first touch event on the current drag. */
>      private float mTouchPos;                /* Position of the most recent touch event on the current drag. */
>      private float mLastTouchPos;            /* Position of the touch event before touchPos. */
>      private float mVelocity;                /* Velocity in this direction; pixels per animation frame. */
> +    private final float[] mRecentVelocities;      /* Circular buffer of recent velocities since last touch start. */

Cursed alignment.

::: mobile/android/base/preferences/AndroidImport.java
@@ +21,5 @@
>  
>  import java.util.ArrayList;
>  
>  class AndroidImport implements Runnable {
>      static final private String LOGTAG = "AndroidImport";

Change this to private static final.

::: mobile/android/base/preferences/AndroidImportPreference.java
@@ +15,5 @@
>  import android.util.AttributeSet;
>  import android.util.Log;
>  
>  class AndroidImportPreference extends MultiPrefMultiChoicePreference {
>      static final private String LOGTAG = "AndroidImport";

Same.

::: mobile/android/base/sync/jpake/JPakeClient.java
@@ +37,5 @@
>  import ch.boye.httpclientandroidlib.entity.StringEntity;
>  
>  public class JPakeClient {
>  
> +  private static final String       LOG_TAG                 = "JPakeClient";

Eliminate the block indenting here.

Comment 3

[Chris Kitching [:ckitching]]

Attachment: Finalise large numbers of fields

What, *all* of the block indenting? Well, okay. It's certainly nicer if we get rid of it.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e925a610e68d

Comment 5

[Richard Newman [:rnewman]]

Upstreamed.