1081593 - Remove unnecessary ternary operations

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Kitching [:ckitching]]

Sometimes, we have ternary expressions where one of the output branches is a constant.

In a number of cases, it seems to aid readability if we rephrase using && or ||.
... See patch.

(This also produces a very, *very* binary size (and pre-JIT performance)  improvement)

Comment 1

[Chris Kitching [:ckitching]]

Attachment: Clean up some ternary operators

Comment 2

[Chris Kitching [:ckitching]]

Attachment: Clean up some ternary operators

Comment 3

[Chris Kitching [:ckitching]]

(In reply to Chris Kitching [:ckitching] from comment #0)
> (This also produces a very, *very* binary size (and pre-JIT performance) 
> improvement)

Should read "(This also produces a very, *very* tiny binary size (and pre-JIT performance) 
 improvement)"

.. A rather important word in context.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8503702 [details] [diff] [review]
Clean up some ternary operators

Review of attachment 8503702 [details] [diff] [review]:
-----------------------------------------------------------------

Upstream plz.

Comment 5

[Chris Kitching [:ckitching]]

https://hg.mozilla.org/integration/fx-team/rev/a95e2de845ff

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a95e2de845ff