Closed
Bug 108164
Opened 23 years ago
Closed 23 years ago
small window extra border bug
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: bouvigne, Assigned: bzbarsky)
References
()
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
3.69 KB,
patch
|
timeless
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
Load http://www.mp3-tech.org. Then look at the upper right corner, near "what's new". With 0.9.5 there is an extra window border inside the rendering window. This occurs on win2k sp1, and didn't occured with 0.9.4.
Comment 1•23 years ago
|
||
In the source of http://www.mp3-tech.org/mainpage.html you can see that there are two encapsulated framesets where the outer has border="false" and the like but the inner has not. I think the border comes from the second frameset. According to HTML standards you should have a frameborder="0" and the like on the frames themselves.
Assignee | ||
Comment 2•23 years ago
|
||
No, descendants should get the frame width and existence from ancestors. This inheritance was broken when code was moved from Reflow() to Init() I've got a fix that's 90% right. I'll attach a patch as soon as I finish ironing out the last 10%.
Assignee: asa → bzbarsky
Status: UNCONFIRMED → NEW
Component: Browser-General → Layout
Ever confirmed: true
Keywords: regression
OS: Windows 2000 → All
Hardware: PC → All
Assignee | ||
Comment 3•23 years ago
|
||
Assignee | ||
Comment 4•23 years ago
|
||
hyatt, would you review?
Assignee | ||
Comment 5•23 years ago
|
||
Attachment #56564 -
Flags: review+
Assignee | ||
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
Comment on attachment 56565 [details] [diff] [review] same but add a missing ")" so it builds. :) sr=attinasi
Attachment #56565 -
Flags: superreview+
Comment on attachment 56565 [details] [diff] [review] same but add a missing ")" so it builds. :) whoops, yeah i see it.
Attachment #56565 -
Flags: review+
Attachment #56564 -
Attachment is obsolete: true
Attachment #56564 -
Flags: review+
Attachment #56300 -
Attachment is obsolete: true
Assignee | ||
Comment 9•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•