108170 - Decimal separator ',' (comma) on german keyboard (on keypad/numpad) shows up as '|' (pipe)

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Andreas M. "Clarence" Schneider]

My system: SuSE 7.1 / KDE, german keyboard, fresh (english) Mozilla CVS build.

If I press the decimal separator in the numeric block of the keyboard (this is
supposed to be a comma on german keyboards) I get a vertical bar ('|') instead
(everywhere I can type text in Mozilla).

This is because GDK_KP_Separator is translated into '|' in nsGtkEventHandler.cpp, 
but should be ','.

Comment 1

[Andreas M. "Clarence" Schneider]

Attachment: gtk1 patch

Comment 2

[Matthias Versen [:Matti]]

1.1alpha is gone..

[e-mail] (Andreas M. "Clarence" Schneider) : 
You must request a review via mail. (if the patch isn't out of date)

Are you still there ?

Comment 3

[David Hyatt]

--> default owner

Comment 4

[John Morrison]

Is this still an issue, and if so, is the patch the appropriate fix. (Sorry 
for the fact that this has not moved anywhere).

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 205533 has been marked as a duplicate of this bug. ***

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 218283 has been marked as a duplicate of this bug. ***

Comment 7

[Christopher Blizzard (:blizzard)]

Is the seperator on english keyboards a slash?

Comment 8

[Frederic Crozat]

According to gtk2 source, 0xFFAC (KP_Separator) is supposed to produce ',',
while KP_Decimal is supposed to produce a '.'

KP_Separator is not present on English keyboard. But it is in some european
countries, instead of KP_Decimal, such as finnish (see bug
http://bugs.mandrakelinux.com/query.php?bug=376 )

The problem is present in both gtk1 and gtk2 version of mozilla (in
source/widget/src/gtk2/nsGtkKeyUtils.cpp for gtk2)

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 193560 has been marked as a duplicate of this bug. ***

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 159733 has been marked as a duplicate of this bug. ***

Comment 11

[Alexander Skwar]

Attachment: Patch against GTK2 source tree

The problem still exists in current builds. This patch fixes the GTK2 source
tree in the same way, as the GTK1 patch does.

Comment 12

[Alexander Skwar]

Comment on attachment 160938 [details] [diff] [review]
Patch against GTK2 source tree

It would be nice, if the old GTK1 patch could also get r/sr.

Comment 13

[Mathias]

Bug is still not resolved. It's annoying if you have to type a lot of numbers...

My system: Fedora core 1; linux 2.4.22-1.2115.nptlsmp; GUI: Gnome-german;
Mozilla 1.7-german,
Keyboard: german

Comment 14

[Andreas Kloeckner]

This bug is still present, confirming with both Firefox 1.0 (Debian package
1.0-4) and Seamonkey 1.7.3 (Debian package 1.7.3-5). Is anything slated to fix
this? It really *is* annoying, especially for online banking.

Comment 15

[Frisco R.]

C'mon dudes! This bug was opened _2001_ and a patch available immediatly and 
it's still not incorporated properly and still present in 2005! I can confirm 
that the same problem is present on swedish keyboards too. Feels awkward to DL 
the source and recompile to fix a _oneline_ bug. Good work on the rest 
nonetheless.. ;-)

Comment 16

[Martin Creutziger [:MMx]]

hmm... the patch even has r+ already, what happened to sr+?
Is Bryner around to do superreviewing or should we ask s.o. else?

Comment 17

[Asa Dotzler [:asa]]

too late for non-critical fixes. blocking-

Comment 18

[Martin Creutziger [:MMx]]

oops, somehow the 1.8a6- got overridden...

Comment 19

[Rune Maagensen]

Confirming on Danish keyboard, with Ubuntu packages. And with official Firefox 
official binaries. 

Comment 20

[Martin Creutziger [:MMx]]

May I ask _why_ blocking-aviary1.1 was denied? Firefox 1.1 is not scheduled
until June and there are patches, of which one already has r+ - so why not
implement it?

Comment 21

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 160938 [details] [diff] [review]
Patch against GTK2 source tree

low risk patch - just changes the character that's generated for
GDK_KP_Separator

Comment 22

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 160938 [details] [diff] [review]
Patch against GTK2 source tree

a=caillon for 1.8beta

Comment 23

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 56238 [details] [diff] [review]
gtk1 patch

would be nice to have this too in 1.8b - the same patch for gtk2 is already
approved.

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

gtk1:
Checking in widget/src/gtk/nsGtkEventHandler.cpp;
/cvsroot/mozilla/widget/src/gtk/nsGtkEventHandler.cpp,v  <--  nsGtkEventHandler.cpp
new revision: 1.189; previous revision: 1.188
done

gtk2:
Checking in widget/src/gtk2/nsGtkKeyUtils.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsGtkKeyUtils.cpp,v  <--  nsGtkKeyUtils.cpp
new revision: 1.12; previous revision: 1.11
done

marking FIXED.