108236 - charsetOverlay.js treats "intl.charset.detector" pref incorrectly

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Brian Nesse (gone)]

This may, or may not, have some impact on some of the currently open charset
detector bugs.

While converting the JS files from the nsIPref to the
nsIPrefService/nsIPrefBranch interfaces, I noticed that the preference
"intl.charset.detector" was being read in as a LocalizedUnicharPref and written
out as a CharPref. This is wrong. A preference read in as LocalizedUnicharPref
should be written out as a Unichar preference.

Comment 1

[Brian Nesse (gone)]

Attachment: Proposed patch

Comment 2

[Brian Nesse (gone)]

The proposed patch fixes the read/write issues, removes some tabs and makes all
of the whitespace consistent.

Comment 3

[Brian Nesse (gone)]

Sorry, forgot to mention... This patch is not fully tested due to being blocked
by bug 107786 (no menus).

Comment 4

[Roy Yokoyama]

bnesse: On the other hand, I think you should own this bug.
I'll test your patch.
->bnesse

Comment 5

[Brian Nesse (gone)]

I have tested this as far as I can. The functions which set the preference are
apparently never called, probably due to the wrong attribute name being returned
from the event (bug 106749). Clearing blocker status as this is not blocking 106749.

Comment 6

[Brian Nesse (gone)]

Setting 106749 as blocking this bug. I think this is what Roy really meant to do
in the first place.

Comment 7

[Brian Nesse (gone)]

Attachment: Patch updated for charsetOverlay.js changes.

I've updated the patch because recent changes to charsetOverlay.js cause merge
conflicts with the old one. With waterson's checkin for bug 106749 in on the
trunk I have now successfully tested the patch.

Comment 8

[Roy Yokoyama]

Comment on attachment 57518 [details] [diff] [review]
Patch updated for charsetOverlay.js changes.

/r=yokoyama
Thanks, Brian

Comment 9

[Alec Flett]

Comment on attachment 57518 [details] [diff] [review]
Patch updated for charsetOverlay.js changes.

sr=alecf

Comment 10

[Brian Nesse (gone)]

Fix checked in.

Comment 11

[Teruko Kobayashi]

Verified from Roy's comment.