Closed
Bug 1082483
Opened 10 years ago
Closed 10 years ago
Rename Matrix4x4::Translate/Scale to Matrix4x4::PreTranslate/PreScale
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(3 files)
2.83 KB,
patch
|
bas.schouten
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
19.57 KB,
patch
|
bas.schouten
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
1.42 KB,
patch
|
bas.schouten
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
As we did for the Matrix class, we should rename Matrix4x4::Translate/Scale to Matrix4x4::PreTranslate/PreScale.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8504598 -
Flags: review?(bas)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8504600 -
Flags: review?(bas)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8504601 -
Flags: review?(bas)
Assignee | ||
Updated•10 years ago
|
Attachment #8504601 -
Attachment is patch: true
Updated•10 years ago
|
Attachment #8504598 -
Flags: review?(bas) → review+
Updated•10 years ago
|
Attachment #8504600 -
Flags: review?(bas) → review+
Updated•10 years ago
|
Attachment #8504601 -
Flags: review?(bas) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8504598 [details] [diff] [review] part 1 - Rename Matrix4x4::Translate/Scale to Matrix4x4::PreTranslate/PreScale, leaving temporary inlines for the old names https://hg.mozilla.org/integration/mozilla-inbound/rev/cd0e534e1012
Attachment #8504598 -
Flags: checkin+
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8504600 [details] [diff] [review] part 2 - Convert Mozilla code to use the new Matrix4x4::PreTranslate/PreScale method names https://hg.mozilla.org/integration/mozilla-inbound/rev/0f5c20e2b2c2
Attachment #8504600 -
Flags: checkin+
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8504601 [details] [diff] [review] part 3 - Remove the temporary Matrix4x4::Translate/Scale methods https://hg.mozilla.org/integration/mozilla-inbound/rev/145557a8efdf
Attachment #8504601 -
Flags: checkin+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd0e534e1012 https://hg.mozilla.org/mozilla-central/rev/0f5c20e2b2c2 https://hg.mozilla.org/mozilla-central/rev/145557a8efdf
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•