108285 - nsCharsetConverterManager (uconv) depends on chardet

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P2)

Description

[Alec Flett]

there is only one tiny dependency which is causing uconv to depend on the
chardet module - in nsCharsetConverterManager, there is a function
GetCharsetDetectorList(), which enumerates registry entries.. and to get the
registry root, we need NS_CHARSET_DETECTOR_REG_BASE

the simple solution is to just replace the use of NS_CHARSET_DETECTOR_REG_BASE
with the raw character string, but it makes me wonder if
GetCharsetDetectorList() isn't in the wrong location. Maybe it should be in
nsICharsetDetector() instead...

Comment 1

[Alec Flett]

now that I know the default owner, reassigning to me

The reason that this is important is that this means anyone who pulls in uconv
pulls in chardet, and chardet is a very large module with many dependencies

Comment 2

[Alec Flett]

Attachment: the simple solution.. just replace the macro with the value

Comment 3

[Alec Flett]

this got fixed along with another bug

Comment 4

[Teruko Kobayashi]

Changed QA contact to [e-mail].