1082896 - New mail notification shows garbled sender name when name is encoded.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: notification.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141011015303

Steps to reproduce:

Receive a message from a sender that uses encoding in the "From:" header, for example:
From: =?UTF-8?Q?J=c3=b6rg_Knobloch?= <[e-mail]>


Actual results:

The "international" character isn't shown correctly (see enclosed).
Also, the folder notification when hovering over a folder that contains the new message shows the same garbled character. See screenshots enclosed.


Expected results:

"International" character should be shown correctly as in version 24.x. I'm using 33 (beta) since 31.x has too many bugs.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: Bad text in folder popup notification

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: notification2.png

This shows the original bug, bad character in sender's name, in this case
From: "=?windows-1252?Q?Departamento_de_Administraci=F3n?=" <[e-mail]>

plus two more bugs:
Some bits of the message body are displayed verbatim, that is M&aacute;ster instead of Máster.

The new message count of 254 is also wrong.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: folder pop-up.png

Another example of a bad character showing in the folder pop-up.

Comment 4

[Jorg K (CEST = GMT+2)]

I tried version 31.2.0, the current "official" version at time of writing.
Version 31.2.0 does NOT show this problem.

Comment 5

[Joshua Cranmer [:jcranmer]]

Attachment: Fix the popup

This is a relatively easy fix. The hard part is adding a test for this in automated tests--the notification tests go through the alert service, which bypasses the newmail.xul dialog.

Comment 6

[Jorg K (CEST = GMT+2)]

Please excuse my asking: Does this also fix the badly rendered HTML in the body preview?
Refer to attachment notification2.png and comment #2. Displayed is "Máster" instead of "Máster" and "Gestión" instead of "Gestión".

Comment 7

[Wayne Mery (:wsmwk)]

Is this a regression of jsmime checkin?

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 8511589 [details] [diff] [review]
Fix the popup

Review of attachment 8511589 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 9

[Jorg K (CEST = GMT+2)]

Please excuse my asking: Does this also fix the badly rendered HTML in the body preview?
Refer to attachment notification2.png and comment #2. Displayed is "Máster" instead of "Máster" and "Gestión" instead of "Gestión".

Can someone please answer "Yes" or "No.

Comment 10

[Magnus Melin [:mkmelin]]

No, this fix only affects the sender name. So

Comment 11

[Jorg K (CEST = GMT+2)]

"So"?

So what about the body? That looks just as bad (see notification2.png).

Comment 12

[Magnus Melin [:mkmelin]]

(that "So" wasn't meant there.)
We probably need a sample mail to see what the body issue could be about.

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: Two notifications with garbled HTML and the corresponding messages

Here you go.
These are the original messages as they were received together with the screenshots taken when they arrived.

Comment 14

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/26b1b0b09ee3

(In reply to Jorg K from comment #11)
> So what about the body? That looks just as bad (see notification2.png).

This is best handled in a separate bug; it's really two distinct issues.

Comment 15

[Jorg K (CEST = GMT+2)]

HTML issue moved to bug 1108218.

Comment 16

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #7)
> Is this a regression of jsmime checkin?

was it decided this is not a regression?
if it is, what is to blame?

Comment 17

[Jorg K (CEST = GMT+2)]

I feel honoured by the question, but I wouldn't have a clue.
I had to google "jsmime" and found this bug 959309.

Comment 18

[Joshua Cranmer [:jcranmer]]

(In reply to Wayne Mery (:wsmwk) from comment #16)
> (In reply to Wayne Mery (:wsmwk) from comment #7)
> > Is this a regression of jsmime checkin?

Yes. At least, the new mail notification garbling is.

Comment 19

[Joe Sabash [:JoeS1]]

It is a regression, so probably should be uplifted to tb36

Comment 20

[Jorg K (CEST = GMT+2)]

Didn't make it into 36, so should go into 38 (or is this automatic since it's been checked in a while ago?)

Comment 21

[Joshua Cranmer [:jcranmer]]

(In reply to Jorg K from comment #20)
> Didn't make it into 36, so should go into 38 (or is this automatic since
> it's been checked in a while ago?)

If it landed on trunk in 37, and it's not backed out, it'll be in 38.