Closed
Bug 1083159
Opened 10 years ago
Closed 10 years ago
[Loop] Issues reported in Loop locales that need to be fixed before Localization teams starts working
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: oteo, Assigned: crdlc)
References
Details
(Whiteboard: [mobile app][blocking][loop in 1.1])
Attachments
(1 file)
According to the feedback provided by Localization team we need to review and fix this issues in Loop mobile application: 1)Using placeholders so people can move the name of the application and other structures as "Terms of service" > welcome = Welcome to > byProceeding = By proceeding you agree with the > termsOfService = Terms of Service > notAUser = Not a Firefox Hello user yet 2)fix an issue related with the plural form that we were not taking into account > daysLeft = days left 3) a string change > ok=should be OK, not Ok
Reporter | ||
Updated•10 years ago
|
Blocks: Localization_Loop1.1
Summary: [Loop] Issues reported in Loop locales needed to be fixed before Loop teams starts working → [Loop] Issues reported in Loop locales that need to be fixed before Localization teams starts working
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Comment 1•10 years ago
|
||
One more request: please add localization notes to the .properties file, especially if you add placeholders/variables that are not self-explanatory.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8505555 [details]
Github pull request
Before reviewing please ping me
Attachment #8505555 -
Attachment description: WIP → Github pull request
Attachment #8505555 -
Flags: review?(borja.bugzilla)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8505555 [details]
Github pull request
Thanks Francesco
Attachment #8505555 -
Flags: feedback?(francesco.lodolo)
Comment 5•10 years ago
|
||
Comment on attachment 8505555 [details]
Github pull request
String-wise it looks good, even if I'd be happier with less HTML code in strings.
Maybe worth asking feeback from :stas or :gandalf about the l10n.js bits.
Attachment #8505555 -
Flags: feedback?(francesco.lodolo) → feedback+
Updated•10 years ago
|
Attachment #8505555 -
Flags: review?(borja.bugzilla) → review+
Assignee | ||
Comment 6•10 years ago
|
||
in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d7cdd6fc56c8cf038df71811765085ee878a3dbe
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•10 years ago
|
Whiteboard: [mobile app][blocking][loop not in 1.1]
Reporter | ||
Comment 7•10 years ago
|
||
Cristian, after talking with Massimo, we have agreed that this patch can be uplifted to 1.1. Could be so kind of doing it? Thanks a lot!!
Flags: needinfo?(crdlc)
Whiteboard: [mobile app][blocking][loop not in 1.1] → [mobile app][blocking][loop approved for 1.1]
Assignee | ||
Comment 8•10 years ago
|
||
in 1.1: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/dd4c02061ab77d1b394859a1696166a9a6f20c1a
Flags: needinfo?(crdlc)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [mobile app][blocking][loop approved for 1.1] → [mobile app][blocking][loop in 1.1]
Comment 9•10 years ago
|
||
Tested Flame eng v2.0 Gecko-dde9d61 Gaia-7b8df99 Loop version: 1.1 , 2e7c3c2
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•