Closed
Bug 1083515
Opened 10 years ago
Closed 10 years ago
Do something about duplicate languages in language selection
Categories
(Webmaker Graveyard :: Events, defect)
Webmaker Graveyard
Events
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: errietta, Unassigned)
Details
Attachments
(2 files)
When creating an event, language has duplicates like "English (English)" "English (US)" or even "English (Upside Down)", we probably don't need all of these options and it can be confusing
Reporter | ||
Comment 1•10 years ago
|
||
[23:11] < gvn> 3:09 PM <aali> probably the best way to do this would be grab all `xx` locale [23:11] < gvn> 3:09 PM <aali> and find any locale `xx-XX` that does not have `xx` as its base locale
Reporter | ||
Comment 2•10 years ago
|
||
https://github.com/alicoding/language-mapping-list/blob/master/language-mapping-list.js#L157 why is this in a different format from everything else?
Flags: needinfo?(ali)
Attachment #8506403 -
Flags: review?(gavin)
Reporter | ||
Comment 3•10 years ago
|
||
Flags: needinfo?(ali)
Attachment #8506451 -
Flags: review?(ali)
Comment 4•10 years ago
|
||
That's just the locale standard for en@pirate :)
Comment 5•10 years ago
|
||
I don't think we want to remove that :)
Comment 6•10 years ago
|
||
Comment on attachment 8506403 [details] [review] https://github.com/mozilla/webmaker-events-2/pull/216 Just a few things noted on GH, but much better!
Attachment #8506403 -
Flags: review?(gavin) → review-
Comment 7•10 years ago
|
||
I really think we should remove Pirate for Events. It makes absolutely no sense for an event to be conducted in "Pirate English".
Comment 8•10 years ago
|
||
Remove in the event but not in the lang list trio I think
Reporter | ||
Updated•10 years ago
|
Attachment #8506403 -
Flags: review- → review?(gavin)
Comment 9•10 years ago
|
||
s/trio/repo Failed autocorrect >.<
Comment 10•10 years ago
|
||
Comment on attachment 8506451 [details] [review] https://github.com/alicoding/language-mapping-list/pull/2 This repo is mainly use by every one and I'm trying to keep it as a standard for all known locale, and en@pirate is one of them. So, to make sure this is not in the event I think the right thing here is to filter them out in the event specifically and not directly in the repo.
Attachment #8506451 -
Flags: review?(ali) → review-
Comment 11•10 years ago
|
||
Comment on attachment 8506403 [details] [review] https://github.com/mozilla/webmaker-events-2/pull/216 See GH
Attachment #8506403 -
Flags: review?(gavin) → review-
Reporter | ||
Updated•10 years ago
|
Attachment #8506403 -
Flags: review- → review?(gavin)
Comment 12•10 years ago
|
||
Comment on attachment 8506403 [details] [review] https://github.com/mozilla/webmaker-events-2/pull/216 http://i.giphy.com/5dDjN9OaDzJ0Q.gif
Attachment #8506403 -
Flags: review?(gavin) → review+
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•