1083515 - Do something about duplicate languages in language selection

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[Errietta Kostala [:errietta]]

When creating an event, language has duplicates like "English (English)" "English (US)" or even "English (Upside Down)", we probably don't need all of these options and it can be confusing

Comment 1

[Errietta Kostala [:errietta]]

[23:11] < gvn> 3:09 PM <aali> probably the best way to do this would be grab all `xx` locale
[23:11] < gvn> 3:09 PM <aali> and find any locale `xx-XX` that does not have `xx` as its base locale

Comment 2

[Errietta Kostala [:errietta]]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/216

https://github.com/alicoding/language-mapping-list/blob/master/language-mapping-list.js#L157 why is this in a different format from everything else?

Comment 3

[Errietta Kostala [:errietta]]

Attachment: https://github.com/alicoding/language-mapping-list/pull/2

Comment 4

[Ali Al Dallal [:alicoding]]

That's just the locale standard for en@pirate :)

Comment 5

[Ali Al Dallal [:alicoding]]

I don't think we want to remove that :)

Comment 6

[Gavin Suntop [:gvn]]

Comment on attachment 8506403 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/216

Just a few things noted on GH, but much better!

Comment 7

[Gavin Suntop [:gvn]]

I really think we should remove Pirate for Events. It makes absolutely no sense for an event to be conducted in "Pirate English".

Comment 8

[Ali Al Dallal [:alicoding]]

Remove in the event but not in the lang list trio I think

Comment 9

[Ali Al Dallal [:alicoding]]

s/trio/repo

Failed autocorrect >.<

Comment 10

[Ali Al Dallal [:alicoding]]

Comment on attachment 8506451 [details] [review]
https://github.com/alicoding/language-mapping-list/pull/2

This repo is mainly use by every one and I'm trying to keep it as a standard for all known locale, and en@pirate is one of them. So, to make sure this is not in the event I think the right thing here is to filter them out in the event specifically and not directly in the repo.

Comment 11

[Gavin Suntop [:gvn]]

Comment on attachment 8506403 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/216

See GH

Comment 12

[Gavin Suntop [:gvn]]

Comment on attachment 8506403 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/216

http://i.giphy.com/5dDjN9OaDzJ0Q.gif