1084474 - Views are broken [Error: NS_NOINTERFACE accessing nsIScrollBoxObject in calendar-multiday-view.xml]

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Thunderbird/36.0a1 Lightning/3.8a1 BuildID/20141017030201

Calendar views are broken and flickering all the times.

The following error is reported many times in console:
> Error: NS_NOINTERFACE: 
> Source File: chrome://calendar/content/calendar-multiday-view.xml
> Line: 3714

Error is produced on the following query interface call:
> let scrollbox = document.getAnonymousElementByAttribute(this, "anonid", "scrollbox");
> let scrollBoxObject = scrollbox.boxObject.QueryInterface(Components.interfaces.nsIScrollBoxObject);

This regression is probably caused by Bug 979835. See Bug 1083793 for similar issue in Thunderbird.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Marking dependencies as its entirely possible this bug will be fixed by bug 1083793 or its outcome.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

No, it won't be.  You just need to remove the QI here.  BoxObject comes with it's other interfaces already exposed now.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Ah, thanks for the hint! Stefan, can you whip up the patch? rs=me since it sounds fairly simple.

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: 1084474-remove-QI-nsIScrollBoxObject.diff

Here is a patch.

You might want to check if the comment at https://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-multiday-view.xml#2225 is still valid after the BoxObject changes.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8507122 [details] [diff] [review]
1084474-remove-QI-nsIScrollBoxObject.diff

Review of attachment 8507122 [details] [diff] [review]:
-----------------------------------------------------------------

> You might want to check if the comment at
> https://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-
> multiday-view.xml#2225 is still valid after the BoxObject changes.

Checked that, the boxObject still doesn't have the scroll* methods.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Patch for checkin

Comment 7

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/comm-central/rev/542a534abc0a