Closed
Bug 1084665
Opened 10 years ago
Closed 10 years ago
Make reftest-analyzer.xhtml support test/reference images of arbitrary dimensions
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file, 1 obsolete file)
|
4.53 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
layout/tools/reftest/reftest.js hardcodes gBrowser to a size of 800x1000, and reftest-analyzer.xhtml hardcodes these values too. That means that highlighting of differences and getting pixel differences on hover are completely broken for other reftesting harnesses that use different dimensions (such as test_reftests_with_caret.html, which uses 600x600). That's...really annoying, especially when the differences are subtle and you really need the highlighting/hover features to work.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8507269 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8507269 -
Attachment is obsolete: true
Attachment #8507269 -
Flags: review?(dholbert)
Attachment #8507295 -
Flags: review?(dholbert)
|
||
Updated•10 years ago
|
Attachment #8507295 -
Flags: review?(dholbert) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8507295 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/dd11d04e841c
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dd11d04e841c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•