Closed
Bug 1084959
Opened 10 years ago
Closed 10 years ago
(a) = ...; aborts syntax parsing
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
946 bytes,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
I was just looking into JSBench performance and noticed we abort syntax parsing for (a) = ... (assignment with parentheses around LHS). The abort happens in checkAndMarkAsAssignmentLhs, because pn is SyntaxParseHandler::NodeGeneric. This should improve the facebook/chrome and facebook/firefox tests by about 10%. Simple testcase: function f() { function g() { var a; (a) = 3; } return 3; } f();
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8509407 -
Flags: review?(bhackett1024)
Updated•10 years ago
|
Attachment #8509407 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6d519cc677b
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d6d519cc677b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•