1084974 - Appmenu styling is incorrect on OS X 10.10

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

The appmenu currently is being styled incorrectly due to several -moz-apperance: none; rules, we need to remove these to use the new system theme.

I've attached a patch that does this, although I'm not sure what effects it will have on 10.9 and lower, I will test that after I get a build environment set up on it.

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: Before

Comment 2

[Josiah Bruner [:jsbruner]]

Attachment: With patch.

Comment 3

[Josiah Bruner [:jsbruner]]

I just realized there is still blue showing through with my current patch, I'll address that next.

Comment 4

[Josiah Bruner [:jsbruner]]

Attachment: Fix.

Here's the change. I decided that it would make sense to finally remove the blue secondaryPane, and make it platform consistent as well. This will effect 10.9 and lower, but I think for the better.

Richard, do you think that's okay? I'll get an after screenshot for you.

Comment 5

[Josiah Bruner [:jsbruner]]

Attachment: With patch.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8511684 [details] [diff] [review]
Fix.

Review of attachment 8511684 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see the issue on my VM but also with the patch applied it looks good. r=me.

I don't mind if you leave the empty selector but I'm not a fan of this because in DOMi I don't know if it is only empty or not shown because of an error in CSS.

::: mail/themes/osx/mail/primaryToolbar.css
@@ +861,3 @@
>  }
>  
>  #appmenu-popup {

This now empty selector can be removed.

Comment 7

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

Thanks.

Comment 8

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/e6d1e266c21a