Closed Bug 1085007 Opened 10 years ago Closed 9 years ago

Audit improper use of 'callschanged' event for initialization

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1048680

People

(Reporter: drs, Unassigned)

References

Details

In bug 1081811, we're going to remove firing of the 'callschanged' event on MozTelephony when first attaching listeners or when the telephony API becomes ready. See bug 1081811 comment 2 for a more thorough explanation.

In this bug, we should do an audit of our uses of the 'callschanged' event to confirm that we're not abusing it to do any initialization.

I did a quick check and we currently have 2 listeners for this:
https://github.com/mozilla-b2g/gaia/blob/7a381373d1039351126cb903543a21c32e6e3772/apps/callscreen/js/calls_handler.js#L21
https://github.com/mozilla-b2g/gaia/blob/7a381373d1039351126cb903543a21c32e6e3772/apps/callscreen/js/conference_group_handler.js#L27

Neither of these seems to have any initialization code. But we should do a more thorough check once bug 1081811 is ready/lands.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.