Closed
Bug 1085093
Opened 10 years ago
Closed 10 years ago
Toolbar buttons lacks label margins
Categories
(SeaMonkey :: Themes, defect)
Tracking
(seamonkey2.30 wontfix, seamonkey2.31 fixed, seamonkey2.32 fixed, seamonkey2.33 fixed)
RESOLVED
FIXED
seamonkey2.33
People
(Reporter: stefanh, Assigned: stefanh)
Details
(Keywords: regression)
Attachments
(1 file)
1.62 KB,
patch
|
mnyromyr
:
review+
philip.chee
:
approval-comm-aurora+
philip.chee
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/e2b3ecf5916b from bug 1001871 introduced this change in toolbarbutton.css: .toolbarbutton-text { - margin: 0px; + margin: 0 !important; /* !important for overriding global.css */ This mean that any .toolbarbutton-text margin rule not having an !important will get overridden by the above rule. Also, the .toolbarbutton-text margin was over-ruled by the label margin rules in global.css before this change. Iotw, our large toolbar button now lacks label margins. This can easily be seen in the PT and the main toolbars. For example, in the PT there's no space between the folder icon and the label.
Assignee | ||
Updated•10 years ago
|
status-seamonkey2.30:
--- → affected
status-seamonkey2.31:
--- → affected
status-seamonkey2.32:
--- → affected
status-seamonkey2.33:
--- → affected
Assignee | ||
Comment 1•10 years ago
|
||
I'm going to put up a quick fix for aurora/beta... but I think it might be worth improving the current look a bit.
Keywords: regression
Assignee | ||
Comment 2•10 years ago
|
||
Too bad I didn't noticed this before... this will restore the margins. As I said, there is room for improvement, but it might be better to do that in a separate bug.
Comment 3•10 years ago
|
||
Hmm why did they touch the theme files in toolkit if bug 1001871 is Firefox specific?
Updated•10 years ago
|
Attachment #8507521 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8507521 [details] [diff] [review] Restore margins [Approval Request Comment] Regression caused by bug 1001871 User impact if declined: no margin between folders and labels in PT, not enough distance between nav-bar toolbarbuttons. Testing completed (on m-c, etc.): Nope, but the fix is obvious Risk to taking this patch (and alternatives if risky): Very low, it just restores previous behaviour String changes made by this patch: none
Attachment #8507521 -
Flags: approval-comm-beta?
Attachment #8507521 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 5•10 years ago
|
||
http://hg.mozilla.org/comm-central/rev/50dd9f50d92b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.33
Updated•10 years ago
|
Attachment #8507521 -
Flags: approval-comm-beta?
Attachment #8507521 -
Flags: approval-comm-beta+
Attachment #8507521 -
Flags: approval-comm-aurora?
Attachment #8507521 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 6•10 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/dc183e0df1fc http://hg.mozilla.org/releases/comm-beta/rev/02b8a1d209a1
You need to log in
before you can comment on or make changes to this bug.
Description
•