1087148 - [Midori 2.0][New Feature][Settings]Can‘t close "find my device"

Status: RESOLVED INVALID

(Firefox OS Graveyard :: FindMyDevice, defect, P2)

Description

[sync-1]

Created an attachment (id=976276)
 2014-10-16-16-04-15
 
 FFOS2.0 baseline BuildID: 20140916000205
 
 DEFECT DESCRIPTION:
 [New Feature][Settings]Cannot close find my device
 
  REPRODUCING PROCEDURES:
 1.Settings ->Find My Device ->Sign in or create an anccout
 2.Enable find my device ->Disable find my device
  ->find doesn't popup "Enter your password",and doesn't close---KO1
 3.Enter into firefox accounts and sign out
  ->find "find my device" show "Enabled"---KO2
 
  When we press 'Enable Find My Device' some times then we can open 'Enter your password' page.
  
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:serious
 
  REPRODUCING RATE:3/3
 
  For FT PR, Please list reference mobile's behavior:
 
  CONTACT INFO (Name,Phone number):
  Guirw,13289210384

Comment 1

[sync-1]

Attachment: 2014-10-16-16-04-15

Comment 2

[sync-1]

Attachment: jrdlog-Bug 811576

Comment 3

[guirw]

[Blocking Requested - why for this release]:The bug affects the normal use， please change it to blocking-b2g → 2.0. Thanks.

Comment 4

[Wesly Huang (EPM)]

function broke? To Triage it.

Comment 5

[guirw]

Dears,
  The bug appear beacuse we do not consider this situation that Findmydevice application should be disabled when we exit accounts from firefox accounts, so now 'find my device' still show enable when we exit accounts from firefox accounts.

Comment 6

[Wesly Huang (EPM)]

[Triage] ni Alexandre Lissy

Hi Alexandre: Per suggestion you are expert about this area, would you help comment if this is an issue? Thank you.

Comment 7

[:gerard-majax]

Log is useless without enabling "Gaia dumps" in Developper/Settings.

Comment 8

[:gerard-majax]

Works for me on Gecko/Gaia master on Flame.

Comment 9

[:gerard-majax]

Attachment: Working FMD logcat on master

Comment 10

[:gerard-majax]

Attachment: Working FMD logcat on 2.0

Works on my 2.0 pvtbuild:
> [App]
> Vendor=Mozilla
> Name=B2G
> Version=32.0
> BuildID=20141023160201
> SourceRepository=https://hg.mozilla.org/releases/mozilla-b2g32_v2_0
> SourceStamp=f8432250efb7
> ID={3c2e2abc-06d4-11e1-ac3b-374f68613e61}

Comment 11

[:gerard-majax]

(In reply to sync-1 from comment #0)
>  DEFECT DESCRIPTION:
>  [New Feature][Settings]Cannot close find my device
>  
>   REPRODUCING PROCEDURES:
>  1.Settings ->Find My Device ->Sign in or create an anccout
>  2.Enable find my device ->Disable find my device
>   ->find doesn't popup "Enter your password",and doesn't close---KO1

This is unexpected, and bug 1040935 already fixed something like this. Please make sure you have this patch.

>  3.Enter into firefox accounts and sign out
>   ->find "find my device" show "Enabled"---KO2

This could be a consequence of the first issue you spotted.

Comment 12

[Wesly Huang (EPM)]

Hi guirw:

Would you provide log as mentioned in comment#7? As it can't be repro. here.

Currently tend to be device-specific so treat as a candidate to de-nom in coming Triage.

Comment 13

[guirw]

Attachment: log.txt

Comment 14

[guirw]

(In reply to Wesly Huang from comment #12)
> Hi guirw:
> 
> Would you provide log as mentioned in comment#7? As it can't be repro. here.
> 
> Currently tend to be device-specific so treat as a candidate to de-nom in
> coming Triage.

Dears,
  Please check log.txt. Thanks.

Comment 15

[Wesly Huang (EPM)]

Thanks guirw.

Hi Alexandre: would you help take a look the new log? Thanks.

Comment 16

[:gerard-majax]

(In reply to guirw from comment #14)
> (In reply to Wesly Huang from comment #12)
> > Hi guirw:
> > 
> > Would you provide log as mentioned in comment#7? As it can't be repro. here.
> > 
> > Currently tend to be device-specific so treat as a candidate to de-nom in
> > coming Triage.
> 
> Dears,
>   Please check log.txt. Thanks.

I can't see anything obviously wrong there. Maybe mark or guilherme may spot something. I see, however, a lot of lines about time going backward, with a delta around 3000 (secs ? msecs ?).

We also lack logcat timestamps, and we still don't know if/how long you waited after disabling. I see traces of network timeouts in the logs, like:

> I/GeckoDump(29041): [findmydevice] resuming client id refresh
> I/GeckoDump(29041): [findmydevice] POST-ing to https://find.firefox.com/1/validate/: {"assert":"eyJhbGciOiJSUzI1NiJ9.eyJmeGEtZ2VuZXJhdGlvbiI6MTQxMzI2Mzc3NDYwNiwiZnhhLWxhc3RBdXRoQXQiOjE0MTQwMzM3NTMsImZ4YS12ZXJpZmllZEVtYWlsIjoiZ3VpcndAdGNsLmNvbSIsInB1YmxpYy1rZXkiOnsiYWxnb3JpdGhtIjoiRFMiLCJ5IjoiY2MxZGZkZGQxNDUzZDg2OTQyNDg1MWFlZmFkZjMxNGY5ODgwODk3NjEzNTc1ZDQ0YmY4ZGY1ZjY0YWFiZDExMWNiNjdhZWFlODBhYTljM2MyOGY5NWZjYjJhNGZmYWQ4MWRlOWYwMjNiM2ZjZTZiNzdiNDJkZjE5NTYwNzRiZmVmNjUzMWY2ZjE2Y2JhMzJiOWExNDRjMTJhMjRhZDUyNTI5ZTc4NjJjNzQwZDE0MWNjYTc5YTFlYWQ2ZDBkMTY4NzNiMzI3OTY5MGU1M2Q0NTM4ZmNiYjcwODQ4NzQ2NTBmZmEyNTNlODM0M2UwOGU5OWZiZTQ2MzUyYTg4ZjUxOCIsInAiOiJmZjYwMDQ4M2RiNmFiZmM1YjQ1ZWFiNzg1OTRiMzUzM2Q1NTBkOWYxYmYyYTk5MmE3YThkYWE2ZGMzNGY4MDQ1YWQ0ZTZlMGM0MjlkMzM0ZWVlYWFlZmQ3ZTIzZDQ4MTBiZTAwZTRjYzE0OTJjYmEzMjViYTgxZmYyZDVhNWIzMDVhOGQxN2ViM2JmNGEwNmEzNDlkMzkyZTAwZDMyOTc0NGE1MTc5MzgwMzQ0ZTgyYTE4YzQ3OTMzNDM4Zjg5MWUyMmFlZWY4MTJkNjljOGY3NWUzMjZjYjcwZWEwMDBjM2Y3NzZkZmRiZDYwNDYzOGMyZWY3MTdmYzI2ZDAyZTE3IiwicSI6ImUyMWUwNGY5MTFkMWVkNzk5MTAwOGVjYWFiM2JmNzc1OTg0MzA5YzMiLCJnIjoiYzUyYTRhMGZmM2I3ZTYxZmRmMTg2N2NlODQxMzgzNjlhNjE1NGY0YWZhOTI5NjZlM2M4MjdlMjVjZmE2Y2Y1MDhiOTBlNWRlNDE5ZTEzMzdlMDdhMmU5ZTJhM2NkNWRlYTcwNGQxNzVmOGViZjZhZjM5N2Q2OWUxMTBiOTZhZmIxN2M3YTAzMjU5MzI5ZTQ4MjliMGQwM2JiYzc4OTZiMTViNGFkZTUzZTEzMDg1OGNjMzRkOTYyNjlhYTg5MDQxZjQwOTEzNmM3MjQyYTM4ODk1YzlkNWJjY2FkNGYzODlhZjFkN2E0YmQxMzk4YmQwNzJkZmZhODk2MjMzMzk3YSJ9LCJwcmluY2lwYWwiOnsiZW1haWwiOiIzMjRkZjlhNGEzZTY0ODFlODNiNTYxOWQyMGNkNzlmY0BhcGkuYWNjb3VudHMuZmlyZWZveC5jb20ifSwiaWF0IjoxNDE0NzM0MDkwMDE5LCJleHAiOjE0MTQ3NTU3MDAwMTksImlzcyI6ImFwaS5hY2NvdW50cy5maXJlZm94LmNvbSJ9.E8LJvaRH3ZVdRCnbsoOKZzNwwqGAWmVqP7nkslHGx8f4Eu4i0coja8GbadjekZTlOUzvvPW7Ty--EmucYJodXwFPQm3NB65tpXlKA8qlOkXRM0vCytUG-DEGbA2gZA6wRbWtZI77pFf5-3HCoBvo0nycvHop87Ryg7hGh6rIv5MZ8CY4JGRkUKfahP5Bf-_Tkc-GiLSVQqyjPB8-DSq27F2zLd1TpKV48d5XlAxP10UwNKUv-LGrSC90lTi4JpJvNCxvrs6ag_FZzSJdlqYsNZmUp9PbLOzehGmMgU5PM9Yqz7Y1sSQLZbP6i9mz6z7EQPS6Qcl1Ri-ml40pVSQZ7Q~eyJhbGciOiJEUzEyOCJ9.eyJleHAiOjIyMDMxMzQ1MjQwOTMsImF1ZCI6Imh0dHBzOi8vZmluZC5maXJlZm94LmNvbSJ9.f2iEA4bLmRTHeKnqST6WIOv0wcaJfcwkb9HrrkUOYRLcU47x6U6kbg=="}
> I/GeckoDump(29041): [findmydevice] server request timed out!
> I/GeckoDump(29041): [findmydevice] request failed with status 0
> I/GeckoDump(29041): [findmydevice] failed to fetch client id with status: 0

Comment 17

[:gerard-majax]

I see a pending notification on the provided screenshots. If there are issues with FMD, you may receive a notification about it.

We also have no answer to comment 11.

Comment 18

[Guilherme Gonçalves [:ggp]]

Looks like the log is incomplete at the beginning -- it starts when we're requesting a client ID, and not registering --, but what seems to have happened here is that:

1- You enabled FMD;
2- FMD attempted to get a clientid from the server, but that request timed out;
3- While in this state, you won't be able to interact with FMD's toggle in the Settings, causing KO1;
4- A few minutes later, FMD tried to get a clientid again in the background, and succeeded this time;
5- You disabled FMD, and it looks like everything went well this time: you saw the 'Enter your password' dialog, entered it successfully, and FMD got disabled;
6- You re-enabled FMD;
7- You logged out of FxA;

As for FMD remaining enabled after logout, that is intended behavior for now, but we fully realize how strange and counterintuitive it is, and definitely want to change it as soon as possible. Please see bug 1000323 comment 23 and bug 1014816 for what is the expected behavior.

In summary, it looks like the only real issue here for now is KO1, which only happened transiently while FMD couldn't contact the server.

Comment 19

[Wesly Huang (EPM)]

De-tag candidate in coming Triage, as can't repro. here (device specific?) plus the summary in comment#18.

Comment 20

[Wesly Huang (EPM)]

[Triage] de-tag as mentioned above.

Comment 21

[guirw]

Attachment: 0001-comment-pr-811576-New-Feature-Settings-Can-t-close-f.patch

Dears,
  I try to fix the bug. Please help me check it. Thanks.

Comment 22

[:gerard-majax]

(In reply to guirw from comment #21)
> Created attachment 8522050 [details] [diff] [review]
> 0001-comment-pr-811576-New-Feature-Settings-Can-t-close-f.patch
> 
> Dears,
>   I try to fix the bug. Please help me check it. Thanks.

Thanks, but let me ask you to explain why you need this change, and why it works. For now, we have not been able to reproduce the issue on our side, so we cannot even test if it works.

Comment 23

[guirw]

Dears，
  I find some problems about it, please test according to the following steps. Thanks.
  1.Brush machine.
  2.Open findmydevice then disable it.
  3.findmydevice disable without "Enter your password" alert.
  Notice: The problem only appear after Brush machine and only appear once.

Comment 24

[:gerard-majax]

(In reply to guirw from comment #23)
> Dears，
>   I find some problems about it, please test according to the following
> steps. Thanks.
>   1.Brush machine.
>   2.Open findmydevice then disable it.
>   3.findmydevice disable without "Enter your password" alert.
>   Notice: The problem only appear after Brush machine and only appear once.

That's another issue, which somebody has already reported as far as I know, and we have not been able to reproduce either. And I don't understand your statement. What does "brush machine" means ?

Comment 25

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

This is a Find My Device feature request bug, it's a duplicate of existing feature requests and we are _very_ far past the feature landing date for 2.0.

Why is this bug not already closed as invalid?

Comment 26

[Guilherme Gonçalves [:ggp]]

(In reply to guirw from comment #21)
> Created attachment 8522050 [details] [diff] [review]
> 0001-comment-pr-811576-New-Feature-Settings-Can-t-close-f.patch
> 
> Dears,
>   I try to fix the bug. Please help me check it. Thanks.

We do plan on changing FMD's behavior for the FxOS 2.2 release so that logging out of Firefox Accounts disables FMD. Firefox Accounts will be modified by then so that logging out requires the user to re-enter their password. However, until that happens, we don't plan on disabling FMD on logout, and the expected behavior is the one explained in the bugs I mentioned in comment 18.

Comment 27

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Jared Hirsch [:_6a68] [NEEDINFO pls] from comment #25)
> This is a Find My Device feature request bug, it's a duplicate of existing
> feature requests and we are _very_ far past the feature landing date for 2.0.
> 
> Why is this bug not already closed as invalid?

Let me clarify my comments a bit further.

Firefox Accounts implementing secure logout is a feature request for 2.2, which seems to be the desired feature in comment 5.

As ggp explained in comment 18, the observed behavior is correct in version 2.0, except for some behavior that seems to have been caused by a bad network connection. Since nobody can reproduce that behavior, I'm guessing it has to do with the local network where the reporter found the bug, so it's invalid.

I don't understand comment 23, but it would be best to open a new bug, and try again to translate the STR into English ("brush machine" doesn't make sense, sorry).

I'm going to go ahead and close this bug, I don't think we have anything else to cover here.