Closed Bug 1087383 Opened 10 years ago Closed 10 years ago

Add a test that sets the wallpaper from Gallery, by long press on the screen

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 fixed, b2g-v2.2 fixed)

RESOLVED FIXED
2.1 S9 (21Nov)
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: viorela, Assigned: viorela)

Details

Attachments

(2 files)

Add an automated test for moztrap test case: https://moztrap.mozilla.org/manage/case/1902/
Assignee: nobody → viorela.ioia
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]
Attachment #8519864 - Flags: review?(robert.chira)
Attachment #8519864 - Flags: review?(jlorenzo)
Attachment #8519864 - Flags: review?(florin.strugariu)
Comment on attachment 8519864 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/25583

Looks good to me. In the last assertion, we check that strings representations of Blobs are not equals[1]. We could extract the data of the Blobs to check they are different. It sounds too overkill to do with Python though.

[1] {u'slice': None, u'type': u'image/png', u'size': 224580} != {u'slice': None, u'type': u'image/jpeg', u'size': 100045}
Attachment #8519864 - Flags: review?(jlorenzo) → review+
Comment on attachment 8519864 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/25583

Please see comments in the PR.
Attachment #8519864 - Flags: review?(robert.chira) → review-
Attachment #8519864 - Flags: review- → review?(robert.chira)
Comment on attachment 8519864 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/25583

Merged to master:
https://github.com/mozilla-b2g/gaia/commit/df56f87092baf8ed4aa954ec5078a320e525c408

Viorela, can you check if this can be uplifted to 2.1 please?
Flags: needinfo?(viorela.ioia)
Attachment #8519864 - Flags: review?(robert.chira)
Attachment #8519864 - Flags: review?(florin.strugariu)
Attachment #8519864 - Flags: review+
Pr for v2.1
Flags: needinfo?(viorela.ioia)
Attachment #8520458 - Flags: review?(robert.chira)
Attachment #8520458 - Flags: review?(florin.strugariu)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: