1089032 - Invalid mochitests skipped in dom/encoding/test/unit/mochitest.ini

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kelsey Gilbert [:jgilbert]]

> 16:07:15     INFO -  Warning: test_big5.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_euc-jp.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_euc-kr.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_gbk.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_iso-2022-jp.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_shift_jis.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test

Comment 1

[Vaibhav (:vaibhav1994)]

Attachment: manifest.patch

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2bef064321aa

Comment 2

[Vaibhav (:vaibhav1994)]

Attachment: manifest.patch

The jobs are green and no warnings for above tests. :jmaher, please review this too!

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8514417 [details] [diff] [review]
manifest.patch

Review of attachment 8514417 [details] [diff] [review]:
-----------------------------------------------------------------

i am concerned about this one, but reducing the directory tree is a really good thing.

Have you verified that dom/encoding tests all run with this patch?

Comment 4

[Vaibhav (:vaibhav1994)]

Yes the number of tests run are the same. This directory is run on chunk 2 of linux.
Comparing https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2bef064321aa and https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1c0d59cc20bb, we see that the number of tests ( 266683/0/24276 ) is the same. Also, :ted commented in https://bugzilla.mozilla.org/show_bug.cgi?id=983867#c7 regarding removing the files, so I think this seems reasonable.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e7f26a5021

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9e7f26a5021