1089446 - Remove ancient and unused Perl scripts

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nicholas Nethercote [inactive]]

By my count we currently have 94 Perl scripts in the repo. Some of them are imported third-party code, some of them are still useful, but some of them are unused. This bug is about eliminating the latter category.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove netwerk/test/neckoTiming.pl, which is ancient and unused

neckoTiming.pl was added in 2001 as part of the "Neck [sic?] Page Load Timer".
It hasn't been touched since then, and I suspect it's unused.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Remove gfx/tests/process-textruns.pl, which is ancient and unused

roc says this is unused.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Reimplement build/unix/uniq.pl in Python, and remove its unit test

build/unix/uniq.pl is a script that prints its given arguments with duplicates
removed. Almost trivial, but implemented in surprisingly many lines of Perl.
(To be fair, it implements some options that we no longer need.)

This patch:

- Reimplements the script as a Python almost-one-liner.
  
- Removes the test, which IMO is unnecessary for something so simple. (The test
  was also surprisingly many lines.)

- Removes the corresponding test harness, which contained just this one test.

 8 files changed, 12 insertions(+), 385 deletions(-)

Huh.

One thing to note is that uniq.py doesn't preserve the original ordering, and I
think uniq.pl did. But that doesn't seem to matter.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8511785 [details] [diff] [review]
Reimplement build/unix/uniq.pl in Python, and remove its unit test

Review of attachment 8511785 [details] [diff] [review]:
-----------------------------------------------------------------

Wow. Just wow.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Improve the comments in both gen_template.pl scripts

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: Remove make-atom-strings.pl, which is ancient and unused

Comment 7

[Nicholas Nethercote [inactive]]

> By my count we currently have 94 Perl scripts in the repo.

Er, make that 97.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8511806 [details] [diff] [review]
Improve the comments in both gen_template.pl scripts

r=me

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8511808 [details] [diff] [review]
Remove make-atom-strings.pl, which is ancient and unused

r=me

Comment 10

[Nicholas Nethercote [inactive]]

Attachment: Remove analyze-xpcom-log.pl, which is ancient and unused

Comment 11

[Nicholas Nethercote [inactive]]

Attachment: Remove config/module2dir.pl, which is ancient and unused

Comment 13

[Mike Hommey [:glandium]]

Comment on attachment 8512261 [details] [diff] [review]
Remove config/module2dir.pl, which is ancient and unused

Your patch is empty, and it's also bug 1089855

Comment 14

[Patrick McManus [:mcmanus]]

Comment on attachment 8511769 [details] [diff] [review]
Remove netwerk/test/neckoTiming.pl, which is ancient and unused

Review of attachment 8511769 [details] [diff] [review]:
-----------------------------------------------------------------

please also remove PageList.txt which is the script's old input

Comment 15

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=542b497abeba

Comment 16

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64c5c57286bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/82e3c989ec64
https://hg.mozilla.org/integration/mozilla-inbound/rev/693baa2d9ba9
https://hg.mozilla.org/integration/mozilla-inbound/rev/134b583fd7ab
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e670b286999
https://hg.mozilla.org/integration/mozilla-inbound/rev/61c2235ebf16

Comment 17

[Nicholas Nethercote [inactive]]

I over-counted initially. We're down to 88 now.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64c5c57286bd
https://hg.mozilla.org/mozilla-central/rev/82e3c989ec64
https://hg.mozilla.org/mozilla-central/rev/693baa2d9ba9
https://hg.mozilla.org/mozilla-central/rev/134b583fd7ab
https://hg.mozilla.org/mozilla-central/rev/9e670b286999
https://hg.mozilla.org/mozilla-central/rev/61c2235ebf16