1089658 - NFC: b2g crashes when trying to read MIFARE Classic tag

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

Attachment: mifare_classic_crash.log

Recently I've noticed that each time I try to read a MIFARE Classic tag, b2g crashes. I know that we don't support MIFARE Classic, but trying to read it should not cause such problem.

In the attached log you can see a segmentation fault just after nfcd tries to notify gecko about the discovered tag:
>D/NfcNci  (  299): doCheckNdefResult: flag all unknown
>D/NfcNci  (  299): doCheckNdef: exit; status=0x3
>E/NfcNci  (  299): doReadNdefInfo: Check NDEF Failed - status = 3
>D/nfcd    (  299): processNotificaton notification=2001
>D/nfcd    (  299): void NfcIpcSocket::writeToOutgoingQueue(uint8_t*, size_t) enter, data=0xb7dcdd68, dataLen=28
>D/nfcd    (  299): Writing 28 bytes to gecko 
>D/NfcNci  (  299): doPresenceCheck
>I/BrcmNfcNfa(  299): NFA_RwPresenceCheck
>I/BrcmNfcNfa(  299): NFC_Deactivate 5 (OPEN) deactivate_type:1
>F/libc    (  294): Fatal signal 11 (SIGSEGV) at 0x00000380 (code=1), thread 294 (b2g)

Comment 1

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: nfcd with debug message

Hi Krzysztof,
Could you help update the attached nfcd and add |-v theadtime| to dump log again ? Thanks for help

Comment 2

[Krzysztof Mioduszewski[:tauzen]]

Sure, but could you paste the command needed update nfcd? (I haven't done this before myslef)

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Ok, figured this out. 
But actually, after doing ./repo sync -d and full build the error does not happen anymore. I assume this might be related to switching back and forth form QCRIL image to regular master. I'll leave this open for couple more days and if it won't occur I'll close this bug as invalid if it's ok with you.
Sorry for all the trouble.

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

Yes

Bug if this bug is reproduced,
You can use "adb push nfcd /system/bin/" to update nfcd, and then reboot device dump the log again, please also add -v threadtime when dumping adb log, thanks

Comment 5

[Dimi Lee [ooo 16.04 - 21.04］]

Hi krzysztof,
Can this issue still be reproduced ? If not, i would suggest we close this bug.

Comment 6

[Krzysztof Mioduszewski[:tauzen]]

I actually had experienced this yesterday on a Friday build. I just want to do a fresh build today, if everything will be ok I'll close this. Will remove ni, once I did the final test.

Comment 7

[Krzysztof Mioduszewski[:tauzen]]

Ok, i replicated this once more on todays build:
Gecko:
commit 1e0235c7b7f910135090e4f72f9f30ae74c12162
Merge: 4a1ad5b 00198ea
Author: Wes Kocher <[e-mail]>
Date:   Mon Nov 10 18:14:04 2014 -0800

    Merge b2g-inbound to m-c a=merge

nfcd:
commit 91a2872824a81dea949f0b57a1399dade5d4d1ea
Merge: 2cb1db1 d65b31e
Author: Yoshi Huang <[e-mail]>
Date:   Fri Nov 7 19:50:54 2014 +0800

    Merge pull request #72 from allstarschh/Bug1055460
    
    Bug 1055460 - replace config with power request. r=dimi

Comment 8

[Krzysztof Mioduszewski[:tauzen]]

Attachment: mifare_classic_crash_2.log

Log with debug nfcd and threadtime

Comment 9

[Dimi Lee [ooo 16.04 - 21.04］]

Hi krzysztof,
Is this issue 100% reproducible when tap the tag ?

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I saw this on my debug build.

12-10 22:31:59.420: A/MOZ_Assert(916): Assertion failure: tech < NFCTechType::EndGuard_, at ../../../gecko/dom/nfc/gonk/NfcService.cpp:130

Comment 11

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: pull request to mozilla-b2g/platform_system_nfcd v1

Comment 12

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: WebIDL change v1

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8554363 [details] [diff] [review]
WebIDL change v1

Review of attachment 8554363 [details] [diff] [review]:
-----------------------------------------------------------------

need review from a DOM peer.

Comment 14

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 8554363 [details] [diff] [review]
WebIDL change v1

Review of attachment 8554363 [details] [diff] [review]:
-----------------------------------------------------------------

r? to smaug for WebIDL change

Comment 15

[Dimi Lee [ooo 16.04 - 21.04］]

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6e299616fe0

Comment 16

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: WebIDL change v2

Update patch description

Comment 17

[Dimi Lee [ooo 16.04 - 21.04］]

need rebased nfcd base on bug 1125041

Comment 18

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: pull request to mozilla-b2g/platform_system_nfcd v2

Hi Yoshi,
Please help review again because there is some changed due to rebase on bug 1125041

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/9b56103db0ce

Master: https://github.com/mozilla-b2g/platform_system_nfcd/commit/d19dad5844e8803d5e88d1577a2742b4f5cbc467

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9b56103db0ce

Comment 21

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: pull request to mozilla-b2g/platform_system_nfcd 2.2

Comment 22

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 8554971 [details] [diff] [review]
WebIDL change v2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
New bug

User impact if declined: 
b2g crash when reading NFC mifare-classic tag type

Testing completed: 
Manually test with mifare-classic tag

String or UUID changes made by this patch:
None

Comment 23

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 8555594 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd 2.2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
New bug

User impact if declined: 
b2g crash when reading NFC mifare-classic tag type

Testing completed: 
Manually test with mifare-classic tag

String or UUID changes made by this patch:
None

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/aeff9ec9a901

v2.2: https://github.com/mozilla-b2g/platform_system_nfcd/commit/de927361215b03e8aaa39ff25b3e691520417cb4