1089662 - Consider moving /nominate javascript + template code outside of fireplace

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Mathieu Pillard [:mat]]

/nominate lives in fireplace, which means its template and javascript code are inlined in include.js. That represents (before minification+gzip):

4.0K	nominate.html (twice that size once inlined in include.js, lots of HTML + conditions & loops in that template)
8.0K	/media/js/views/nominate.js
4.0K	/media/js/views/nominate.styl

We would reduce the size of include.{js,css} by having that view served outside fireplace somehow. It's non-essential to fireplace, I don't even know how to reach it from the homepage.

Comment 1

[Wil Clouser [:clouserw]]

Scott says we can drop this page completely if we like.

Comment 2

[Mathieu Pillard [:mat]]

Awesome. Let's do that.

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/c49cebd2cd7d5297dac67773174cee35b5005293

Comment 4

[Amy Tsay [:amyt]]

We can't remove the page; the link is out there and I don't want people landing on a broken page. If there's a way to keep the page without too much trouble that would be great. Otherwise, we need to have a redirect. Scott can put up a blog post we can redirect to.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Amy Tsay [:amyt] from comment #4)
> We can't remove the page; the link is out there and I don't want people
> landing on a broken page. If there's a way to keep the page without too much
> trouble that would be great. Otherwise, we need to have a redirect. Scott
> can put up a blog post we can redirect to.

Amy, on average how many submissions do we get right now?

––

It sounds like it shouldn't, but if it has to go down, redirect to https://wiki.mozilla.org/Marketplace/Contributing/Apps/CommunityCuration

But that still doesn't say how to nominate apps.

Amy, what is the expected route for folks to nominate featured apps to the Marketplace? Is this Nominate page it? Or emailing Scott? It's at least unclear from the Marketplace homepage how to do that. So I'm assuming on the newsletters it's more clear.

Comment 6

[Amy Tsay [:amyt]]

We get a dozen or so per month. You're right, it isn't clear, partly because v1 of the program was invite-only. Let's wait for Scott to write the blog post, which will clarify things, and redirect to that instead.

Also want to give Scott a chance to chime in on whether he wants to keep the page or consolidate everything to the as-yet-unwritten blog post.

Comment 7

[sdevaney]

The number of app noms we receive each month varies, but we got 14 in October. 

If we take down the Nomination page, I can write a blog post that essentially conveys the same info and asks folks to send app nominations to [e-mail], which comes directly to me. We can also link to the wiki page form the blog post.

Comment 8

[Mathieu Pillard [:mat]]

Scott: please write the blog post then. Not having this page means less code to maintain and less content to download (since we bundle all consumer pages together) so it improves Marketplace performance.

When the post is up, give the URL here and we'll set up the redirect.

Comment 9

[sdevaney]

Cool. I'll have something written up by the end of this week.

Comment 10

[sdevaney]

Here's the blog post we can redirect to:

https://blog.mozilla.org/apps/2014/11/08/got-a-favorite-app-on-firefox-marketplace-lets-feature-it/

Comment 11

[Mathieu Pillard [:mat]]

The redirection was added to dev/stage in bug 1096495, it should go in production with the next push.