1090276 - Add mach target for cpp unittests on Android and B2G

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Dan Minor [:dminor]]

Bug 949538 added a mach target to run cppunittests for desktop builds. Since we also support these tests on Android and B2G, we should add support to mach for this use case as well.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: add mach cppunittest support for android

I've used the mochitest mach command for inspiration and tried to use a similar (but simpler) structure. This only adds special handling for android; I think b2g would be easy to add, but I'm less comfortable with that...will leave open for b2g follow-up.

I have tested with "mach cppunittest" and "mach cppunittest <objdir>/dist/TestFile" on both Android and Linux. Also: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1fb27ebb622

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8660099 [details] [diff] [review]
add mach cppunittest support for android

Review of attachment 8660099 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b89b4f875deb

Comment 4

[Geoff Brown [:gbrown]]

Leaving open for b2g.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b89b4f875deb

Comment 6

[Chris Cooper [:coop] (he/him)]

Only b2g left. Closing.

Comment 7

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.