1090380 - Torn-off developer tools (in separate window) have no indication of which page they're targeting

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1)  Open developer tools.
2)  Click the little "Show in separate window" icon in the top right of the
    devtools, to the left of the little "x".

EXPECTED RESULTS: Developer tools torn off into a new window that has some indication of which page it's targeting.

ACTUAL RESULTS: There is no such indication in the new window.

Comment 1

[Boris Zbarsky [:bzbarsky]]

For comparison, DOM inspector shows the url of the thing being inspected.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Screen Shot 2014-10-28 at 10.05.50 AM.png

Looks like the title of the window is "<panel> - <url>" to me. I think it would be an improvement to make it "<panel> - <title> - <url>" or even simply "<panel> - <title>".

What am I missing?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Ah, so it is.  I completely missed that; I guess I habitually ignore window titlebars.  :(

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> Created attachment 8512808 [details]
> Screen Shot 2014-10-28 at 10.05.50 AM.png
> 
> Looks like the title of the window is "<panel> - <url>" to me. I think it
> would be an improvement to make it "<panel> - <title> - <url>" or even
> simply "<panel> - <title>".

The <panel> portion is redundant, since the section headers right below already show what panel is selected. I agree that we should put the title of the webpage in the window title in front of the URL.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> (In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> > Created attachment 8512808 [details]
> > Screen Shot 2014-10-28 at 10.05.50 AM.png
> > 
> > Looks like the title of the window is "<panel> - <url>" to me. I think it
> > would be an improvement to make it "<panel> - <title> - <url>" or even
> > simply "<panel> - <title>".
> 
> The <panel> portion is redundant, since the section headers right below
> already show what panel is selected. I agree that we should put the title of
> the webpage in the window title in front of the URL.

I think it is useful when Cmd+Tab'ing on OSX where you can only see the icon + window title. It differentiates the tools window from the browser window. Not sure if other OSs are similar.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Note bug 1224302 -- we've now gone to showing the title but not the url.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Any consensus on what we *should* show?  The undocked page toolbox currently shows:

<panel> - <title>

however in cases where we don't have the title (workers), we might show:

<panel> - <url>

Should we always should URL?  If so, is the title there too?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

We could potentially do something to the actual tab in the browser, like displaying the wrench on top of the favicon like we do with the sound-playing icon.

Comment 9

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #7)
> Any consensus on what we *should* show?  The undocked page toolbox currently
> shows:
> 
> <panel> - <title>
> 
> however in cases where we don't have the title (workers), we might show:
> 
> <panel> - <url>
> 
> Should we always should URL?  If so, is the title there too?

I think showing <panel> is redundant. I think <title> — <url> should suffice.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

<title> - <url> is still ambiguous for developers who may have a page open in multiple tabs exhibiting various states.

Comment 11

[Boris Zbarsky [:bzbarsky]]

> We could potentially do something to the actual tab in the browser

That wouldn't help much in my case because the browser window may not even be visible (hidden behind other windows, on a different virtual desktop, etc).

Comment 12

[Brian Grinstead [:bgrins]]

I think "DevTools - <url>" would be nice since you can still tell it's devtools when windowing in the OS as in Comment 5, but it gets rid of the redundant information about selected panel.  And it will go back to showing the URL.  I didn't mean to change it to <title> in Bug 1211017, that was intended only for web/service worker toolboxes.

Comment 13

[Brian Grinstead [:bgrins]]

(In reply to (Unavailable until 3-7) Brian Grinstead [:bgrins] from comment #12)
> I think "DevTools - <url>"

Although it should be "Developer Tools" instead of "DevTools" to match other strings in the UI (like in options panel)

Comment 14

[Tim Nguyen :ntim]

Perhaps we could also display a wrench on every tab that has developer tools opened in the tabbar ? That would help spotting the debugged tab faster.

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1090380 - Show target title and URL in toolbox title. r=bgrins

Review commit: https://reviewboard.mozilla.org/r/50315/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50315/

Comment 16

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1090380 - Set a basic target name for workers. r=bgrins

Review commit: https://reviewboard.mozilla.org/r/50317/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50317/

Comment 17

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=16ff5a08099c

Comment 18

[Brian Grinstead [:bgrins]]

Comment on attachment 8748484 [details]
MozReview Request: Bug 1090380 - Show target title and URL in toolbox title. r=bgrins

https://reviewboard.mozilla.org/r/50315/#review47247

Comment 19

[Brian Grinstead [:bgrins]]

Comment on attachment 8748485 [details]
MozReview Request: Bug 1090380 - Set a basic target name for workers. r=bgrins

https://reviewboard.mozilla.org/r/50317/#review47249

::: devtools/client/framework/target.js:739
(Diff revision 1)
>    get isTabActor() {
>      return true;
>    },
>  
> +  get name() {
> +    return "Worker";

I think this is the same target that's used for service workers.  It's probably OK since Worker is generic, but it'd also be nice to distinguish between service workers / shared workers / web workers (I don't know how easy that is to do from the Target though).

Comment 20

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://reviewboard.mozilla.org/r/50317/#review47249

> I think this is the same target that's used for service workers.  It's probably OK since Worker is generic, but it'd also be nice to distinguish between service workers / shared workers / web workers (I don't know how easy that is to do from the Target though).

Yes, it is the same, so they will all show "Worker" in the title for now.  Actually, I tried to wire up the real type first, just like you're suggesting, but it was complicated than I wanted to tackle at the moment.  We can improve this later on if someone wants it.

Comment 21

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54258f161545

Comment 22

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5c67b7d85fb

Comment 23

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c959c761aa4f
https://hg.mozilla.org/integration/fx-team/rev/98730e9d1455

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c959c761aa4f
https://hg.mozilla.org/mozilla-central/rev/98730e9d1455

Comment 25

[Md.Tarikul Islam Oashi]

I have reproduced this bug with Nightly 36.0a1 (2014-10-28) on Linux Mint, 64 Bit !

The Bug's fix verified on Latest Aurora 49.0a2 .

Build ID 	20160708004052
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0