1090615 - [commbadge] Comments for Reviewers are showing up as Reviewer Comments

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Kevin Ngo [:ngoke]]

An oversight that makes Comments for Reviewers read as Reviewer Comment. A migration will need to be run to fix the Comments for Reviewers for all of the apps.

STR:

1. Submit an app.
2. Leave a Comments for Reviewers in the process.
3. Go to the Commbadge thread for that app.

Expected:

Note reads "Developer Comment"

Actual:

Note reads "Reviewer Comment"

Comment 1

[Kevin Ngo [:ngoke]]

To make things worse, a Reviewer Comment on the review history page was accidentally made equivalent to a Reviewer Comment where a reviewer comments on a Commbadge thread. The former comment would be private from the developer, while the latter is public.

Comment 2

[Kevin Ngo [:ngoke]]

Updating the STR:

1. Update a packaged app with a new version.
2. Leave something in the "Notes for Reviewers" section.
3. Go to the Commbadge thread for that app.

Expected:

Note reads "Developer Note for Reviewer" or something similar.

Actual:

Note reads "Reviewer Comment"

Comment 3

[Kevin Ngo [:ngoke]]

This is currently on -dev, not yet on stage.

Comment 4

[Andrew Williamson [:eviljeff]]

what's the commit/pr?

Comment 5

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/e343d19066e04a8b04de77f506ebb805dd3259ef

It was an oversight since "approvalnotes" sounded a lot like something a reviewer would do.

Comment 6

[Iulian Timis]

Verified as fixed in https://marketplace.allizom.org/comm/ on FF36 (Win 7).
Postfix screencast http://screencast.com/t/zaMV4WGp
Closing bug.