1090689 - Add MPL2.0 to treeherder-[repos] where applicable

Status: VERIFIED FIXED

(Tree Management :: Treeherder, enhancement, P2)

Description

[Jonathan French (:jfrench)]

Just crossed my mind, we might want to inject the MPL2.0 header into relevant file types into applicable treeherder repos.

js:

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, you can obtain one at http://mozilla.org/MPL/2.0/. */

py:

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, you can obtain one at http://mozilla.org/MPL/2.0/.


And any other file types we might like.

Comment 1

[Ed Morley [:emorley]]

Bah good spot, we really should have been doing this from the start.

Gerv, I'm presuming I need an ack from contributors before adding the header - do I need it from contributors who are employees, or is that a given with their contracts?

The repos are:
https://github.com/mozilla/treeherder-service
https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-client (though this one seems to have mostly correct headers already)

Comment 2

[Ed Morley [:emorley]]

Contributor lists:

curl https://api.github.com/repos/mozilla/treeherder-service/contributors | grep 'html_url'
    "html_url": "https://github.com/camd",
    "html_url": "https://github.com/maurodoglio",
    "html_url": "https://github.com/jeads",
    "html_url": "https://github.com/edmorley",
    "html_url": "https://github.com/pnispel",
    "html_url": "https://github.com/uberj",
    "html_url": "https://github.com/KWierso",
    "html_url": "https://github.com/lightsofapollo",
    "html_url": "https://github.com/tojonmz",
    "html_url": "https://github.com/jonasfj",
    "html_url": "https://github.com/Ako0",
    "html_url": "https://github.com/AutomatedTester",
    "html_url": "https://github.com/sylvestre",

curl https://api.github.com/repos/mozilla/treeherder-ui/contributors | grep 'html_url'
    "html_url": "https://github.com/camd",
    "html_url": "https://github.com/jeads",
    "html_url": "https://github.com/maurodoglio",
    "html_url": "https://github.com/tojonmz",
    "html_url": "https://github.com/edmorley",
    "html_url": "https://github.com/wlach",
    "html_url": "https://github.com/pnispel",
    "html_url": "https://github.com/Ako0",
    "html_url": "https://github.com/KWierso",
    "html_url": "https://github.com/AutomatedTester",
    "html_url": "https://github.com/lightsofapollo",
    "html_url": "https://github.com/sylvestre",
    "html_url": "https://github.com/markrcote",
    "html_url": "https://github.com/koddsson",
    "html_url": "https://github.com/mbrubeck",
    "html_url": "https://github.com/laggyluke",
    "html_url": "https://github.com/jeffgodwyll",

curl https://api.github.com/repos/mozilla/treeherder-client/contributors | grep 'html_url'
    "html_url": "https://github.com/jeads",
    "html_url": "https://github.com/maurodoglio",
    "html_url": "https://github.com/camd",

Consolidated:
  https://github.com/Ako0
  https://github.com/AutomatedTester
  https://github.com/KWierso
  https://github.com/camd
  https://github.com/edmorley
  https://github.com/jeads
  https://github.com/jeffgodwyll
  https://github.com/jonasfj
  https://github.com/koddsson
  https://github.com/laggyluke
  https://github.com/lightsofapollo
  https://github.com/markrcote
  https://github.com/maurodoglio
  https://github.com/mbrubeck
  https://github.com/pnispel
  https://github.com/sylvestre
  https://github.com/tojonmz
  https://github.com/uberj
  https://github.com/wlach

Comment 3

[Gervase Markham [:gerv]]

If there's been no license thusfar, or if the license has been stated as MPL 2 elsewhere but was not in the headers (as seems to be the case for treeherder-service, at least - it has a top-level LICENSE.txt file), you don't need anyone's permission.

If you told everyone the license was going to be something else, then you need the permission of non-employee contributors.

The LICENSE.txt file in treeherder-service should be called LICENSE, and should contain a copy of:
https://www.mozilla.org/MPL/2.0/index.txt .

Gerv

Comment 4

[Ed Morley [:emorley]]

That's really helpful - thank you :-)

We've either not stated what licence, or have just listed it in the LICENSE.txt file (and not in the headers), so sounds like we're fine and can just make this change.

Comment 5

[Jonathan French (:jfrench)]

Attachment: ui-jsListAll

I had a quick look at the -ui repo recurisvely from /webapp. Since there's very few py, sh, or other file types, I built a js list for Ed to evaluate. I've split the list into three parts - proposed for headers, proposed excluded, and unknown.

Let me know what alterations are required and I'll inject the desired headers.

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8514447 [details]
ui-jsListAll

Looks good with the following changes:

Unknown:
./test/vendor/  --> exclude
./scripts/web-server.js --> exclude
<everything else in unknown> --> include

Thanks! :-)

Comment 7

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#256

Please see the above PR for treeherder-ui. Setting Ed and/or William for review at their leisure, whoever gets to it first.

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/94371398adf3d326b7b48835e4acd12eea7e26bb
Bug 1090689 - Add MPL2.0 headers to the repo

https://github.com/mozilla/treeherder-ui/commit/3ccfa7466999e8d19273caf705c54e5fea167f96
Merge pull request #256 from tojonmz/add-headers

Bug 1090689 - Add MPL2.0 headers to the repo

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8515180 [details] [review]
treeherder-ui-PR#256

Thanks!

Comment 10

[Jonathan French (:jfrench)]

Thanks wlach! Actually we need this bug still open for part2, which is treeherder-service, and then treeherder-client. I figured on using one bug for all. I'll have a look at service next.

Comment 11

[Jonathan French (:jfrench)]

Attachment: service-listProposed

Here's the proposed treeherder-service header candidates, updating .conf .sh .pp and .py files. I've removed the vendor files already. Adding Ed for feedback.

Let me know if anything needs to be pruned.

Comment 12

[Ed Morley [:emorley]]

Comment on attachment 8515343 [details]
service-listProposed

Looks good (excluding ./addPyHeader.sh), thank you :-)

Comment 13

[Jonathan French (:jfrench)]

Thanks Ed, will do.

Comment 14

[Jonathan French (:jfrench)]

Attachment: treeherder-service-PR#279

Please see the above PR for treeherder-service.

Comment 15

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/dbb4d11e09ba65f2721dc67d5000914c8e5ca6a0
Bug 1090689 - Add MPL2.0 headers to the repo

https://github.com/mozilla/treeherder-service/commit/0d5b02daf52fa9c2637309989798e9518f3a7f80
Merge pull request #279 from tojonmz/add-headers

Bug 1090689 - Add MPL2.0 headers to the repo

Comment 16

[Jonathan French (:jfrench)]

Confirmed landed fine on treeherder-service. On to treeherder-client next.

Comment 17

[Jonathan French (:jfrench)]

Attachment: treeherder-client-PR#6

Please see the above PR for treeherder-client.

Comment 18

[Ed Morley [:emorley]]

Comment on attachment 8524295 [details] [review]
treeherder-client-PR#6

https://github.com/mozilla/treeherder-client/commit/a8186c70aed55677136174fd5cda9ffcdd05514f

(The bugzilla & IRC bots were not set up for treeherder-client, have done the latter now, and emailed Wes for the former, since I don't know the bot gmail account password)

Comment 19

[Jonathan French (:jfrench)]

We think we'd like to also add MPL headers to treeherder-node also. Either lightsofapollo or Ed will move the repo to be under /mozilla first, then after that I'll update the files.

Comment 20

[Ed Morley [:emorley]]

I don't have permission to move James' own repo :-)

Comment 21

[Jonathan French (:jfrench)]

Sorry, ya. James has moved his repo now, he indicated in channel it's under automation. I am not sure if that refers to repo ownership, but anyway it is now here https://github.com/mozilla/treeherder-node

Comment 22

[Ed Morley [:emorley]]

(In reply to Jonathan French (:jfrench) from comment #21)
> Sorry, ya. James has moved his repo now, he indicated in channel it's under
> automation. I am not sure if that refers to repo ownership, but anyway it is
> now here https://github.com/mozilla/treeherder-node

Yeah the repo is under the "automation" team on Github. I've also added the "treeherder" team, set up IRC/Bugzilla hooks, adjusted the README/package.json & also places elsewhere that link to the repo (wiki, READMEs in UI/service). Should be good to go now :-)

Comment 23

[Jonathan French (:jfrench)]

Thanks Ed! Headers update coming up shortly.

Comment 24

[Jonathan French (:jfrench)]

Attachment: treeherder-node-PR#3

Please see above PR for review and status.

Comment 25

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-node

https://github.com/mozilla/treeherder-node/commit/1e9d4f16c2f67763b568db88a0855f8933e9ed5c
Bug 1090689 - Add MPL2.0 headers to the repo

https://github.com/mozilla/treeherder-node/commit/83850072b8d67bdddbbf90afa8b14ad8cecbaa3c
Merge pull request #3 from tojonmz/add-headers

Bug 1090689 - Add MPL2.0 headers to the repo

Comment 26

[Jonathan French (:jfrench)]

I think we are done here, so unless anyone has anything else I'm marking this fixed, and also marking verified based on the current states of the repo.

Comment 27

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/db8f459ddf162f9764041ee5616d960a3bd2276e
Bug 1090689 - Add MPL2.0 headers to the repo

Comment 28

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c93f507e812940c03b00e980c060c0d4e43b78fd
Bug 1090689 - Add MPL2.0 headers to the repo

https://github.com/mozilla/treeherder/commit/5a54c4f869a4f87dd6b0baad5cf743fa15b97b40
Merge pull request #256 from tojonmz/add-headers

Bug 1090689 - Add MPL2.0 headers to the repo