1090694 - [Settings] Dialogs in settings are not responding

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

This was regressed by bug 107600 where we removed the hash of the launch path and added logic blocking the click events from dialogs to prevent from refreshing. The logic should be removed as it prevents some of the dialogs from functioning.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/25594

Could you help review the patch based on what we've discussed? Thanks.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Arthur, can you tell me which kinds of form doesn't work before applying this patch ?

Thanks

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

(In reply to Arthur Chen [:arthurcc] from comment #0)
> This was regressed by bug 107600 where we removed the hash of the launch
> path and added logic blocking the click events from dialogs to prevent from
> refreshing. The logic should be removed as it prevents some of the dialogs
> from functioning.

I meant bug 1007600.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8513221 [details]
link to https://github.com/mozilla-b2g/gaia/pull/25594

Thanks Arthur, I just tested on browser and this seems an interesting tweak to prevent refreshing pages from submitting forms.

r+

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 0bb1d2b49bf728230d0a4f05e83c445c6c7c695f