Closed
Bug 1091031
Opened 10 years ago
Closed 10 years ago
whitelist talky.io for screensharing
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: fippo, Assigned: shell)
Details
(Whiteboard: [Whitelist])
Attachments
(1 file, 2 obsolete files)
1.72 KB,
patch
|
jesup
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.104 Safari/537.36 Steps to reproduce: Please add talky.io to the screensharing whitelist. The privacy policy is available from https://talky.io/help/security -- please ping peter@andyet.com if you have any questions about that. talky.io has been supporting screensharing in Firefox since August but adoption is still low, presumably because users have to manually edit the whitelist. We saw quite an increase when switching from chrome's flag method to the extension. An updated (thanks mreavy) help page is available on https://beta.talky.io/help/screensharing -- should roll out to the main page soon, along with better visibility of the privacy policy.
Updated•10 years ago
|
Assignee: nobody → sescalante
Component: Untriaged → WebRTC
Product: Firefox → Core
Comment 1•10 years ago
|
||
Hi Shell -- Can we ask Mika to look at this today? I'd love to get this into Fx34, if possible. We need to get Mika's "ok"; then I can take care of getting this landed in Nightly and uplifted as far as we can.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(sescalante)
Assignee | ||
Comment 2•10 years ago
|
||
Hi Mika, Can this get approved today? we'd like to uplift into Fx34 (so very short turn-around)
Flags: needinfo?(sescalante) → needinfo?(udevi)
Assignee | ||
Comment 3•10 years ago
|
||
Hi Philip, Sorry - I missed one thing. There's a template coming, but for now can you confirm in this bug that you have seen and agree to our whitelist policy. The policy is posted here, https://wiki.mozilla.org/Screensharing under the "Developer Screensharing Submission Policy" section.
Flags: needinfo?(fippo)
Comment 4•10 years ago
|
||
The policy makes sense. Agreed. Detailed comments below: * Describe to users clearly and accessibly how the screensharing application handles and shares information in connection with the screenshare stream (for example, in a privacy policy or the UI) The privacy policy doesn't mention screensharing yet, but that might be a good idea. Will be updated soon. The UI shows that a screen is shared, both by changing the button text + color and by showing the local screen. * Transmit only the specific content that the user directs to be transmitted (“User Directed Content”) Isn't that the browsers job? Showing the displayed screen/window/app content to the user should address this though since the user "knows" what is shared. * Transmit User Directed Content only to the user’s intended recipients Covered by the privacy policy i think. Subject to the user not being aware of who the recipient is without an IdP, but that is a different problem.
Flags: needinfo?(fippo)
Reporter | ||
Comment 5•10 years ago
|
||
err... account confusion on the previous comment, so signing off the "agreed" with different email as well.
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
fix typo
Updated•10 years ago
|
Attachment #8515530 -
Attachment is obsolete: true
Comment 8•10 years ago
|
||
Include only beta.talky.io and talky.io after discussions with fippo
Updated•10 years ago
|
Attachment #8515561 -
Attachment is obsolete: true
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/32dab69d0013
Whiteboard: [Whitelist]
Comment 10•10 years ago
|
||
Comment on attachment 8515676 [details] [diff] [review] Whitelist talky.io for screensharing Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: needed for users to access screensharing at these sites without hand-editing or installing an extension [Describe test coverage new/current, TBPL]: landed on inbound; will verify on tbpl builds before any uplift. [Risks and why]: virtually no risk, just a sitelist change in a pref [String/UUID change made/needed]: none
Attachment #8515676 -
Flags: review+
Attachment #8515676 -
Flags: approval-mozilla-beta?
Attachment #8515676 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Comment 11•10 years ago
|
||
Comment on attachment 8515676 [details] [diff] [review] Whitelist talky.io for screensharing Approving what is a pretty trivial pref change. I'll note that Randell is testing the change in a try build and will land once the change is verified. Beta+ Aurora+
Attachment #8515676 -
Flags: approval-mozilla-beta?
Attachment #8515676 -
Flags: approval-mozilla-beta+
Attachment #8515676 -
Flags: approval-mozilla-aurora?
Attachment #8515676 -
Flags: approval-mozilla-aurora+
Comment 12•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/15131bc5a356 https://hg.mozilla.org/releases/mozilla-beta/rev/08876d848dcf
Comment 13•10 years ago
|
||
verified on inbound tbpl builds
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/32dab69d0013
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•