1091663 - Run toplevel::base on win2k8

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

There are just a few small tweaks left to make catalogs compile on windows.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug1091663.patch

This requires https://bugzilla.mozilla.org/show_bug.cgi?id=1048962, which you should land soon :)

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8514333 [details] [diff] [review]
bug1091663.patch

Review of attachment 8514333 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/users/manifests/root.pp
@@ +24,4 @@
>  
>      $home = $::operatingsystem ? {
>          Darwin => '/var/root',
> +        Windows => 'C:\Users\Administrator',  # $rlocalpath,

I need help with this part.  $rlocalpath is empty on my test box, so this ends up an empty string and Puppet fails trying to install /.hgrc.  Any idea why?

Comment 3

[Mark Cornmesser [:markco] OOO 2024/04/15]

Attachment: winrootlp.rb

The current version of winrootlp.rb in HG isn't functioning correctly. It had kind of dropped lower on my list. This version works, but i remeber something about it not being very clean code.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Let's get a bug open for that, too, blocking this one.

Comment 5

[Mark Cornmesser [:markco] OOO 2024/04/15]

Comment on attachment 8514333 [details] [diff] [review]
bug1091663.patch

Review of attachment 8514333 [details] [diff] [review]:
-----------------------------------------------------------------

With winrootlp.rb working I would like to stay with $rlocalpath.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug1091663-r2.patch

This assumes winrootlp (bug 1091834) and the extra ' in execonce (bug 1085468) are fixed, as well as the packages::pkgzip define (bug 1048962).

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug1091663-r3.patch

Updated version of the patch after other prereqs have been elimiated; carrying forward the r+

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

http://hg.mozilla.org/build/puppet/rev/ce16896387de