1091885 - ship the 'isolation' CSS property (enable the layout.css.isolation.enabled preference)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should ship the 'isolation' CSS property.  Bugs that need to be fixed before we do this should block this bug.

Initial implementation of the property was in bug 1077872.

(Is anything else needed here, or can we just do this?)

Comment 1

[Rik Cabanier]

Attachment: Turn on 'isolation' by default

Comment 2

[Rik Cabanier]

Comment on attachment 8514691 [details] [diff] [review]
Turn on 'isolation' by default

Sorry, I thought it was turned on by default.

Try build: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=727cf5fb74f8

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Was there thread about shipping this on dev-platform?  If not, could you start one?

Are there any interop risks here in the details (e.g., interacting with painting order or stacking contexts), or is that mostly with mix-blend-mode?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, and what does test coverage look like?  (And are any of those tests in a W3C test suite?)

Comment 5

[Rik Cabanier]

(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) (away/busy Oct. 24-31) from comment #3)
> Was there thread about shipping this on dev-platform?  If not, could you
> start one?

No. Will do so asap.

> Are there any interop risks here in the details (e.g., interacting with
> painting order or stacking contexts), or is that mostly with mix-blend-mode?

This property just creates a stacking context. It should not have any side effects; the try bots should catch this.

Comment 6

[Rik Cabanier]

(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) (away/busy Oct. 24-31) from comment #3)
> Was there thread about shipping this on dev-platform?  If not, could you
> start one?
> 
> Are there any interop risks here in the details (e.g., interacting with
> painting order or stacking contexts), or is that mostly with mix-blend-mode?

(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) (away/busy Oct. 24-31) from comment #4)
> Oh, and what does test coverage look like?  (And are any of those tests in a
> W3C test suite?)

There are a couple of tests for isolation which Firefox is passing.
For the implementation report that I will generate for Peter, I might add a couple more test especially for SVG content and mixed SVG/HTML

Comment 7

[Rik Cabanier]

I'm getting some strange errors from the try run: 
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=727cf5fb74f8

I'm not able to figure out why this is happening. Can you take a quick look?

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Most likely problem is that property_database.js uses 'isolated' instead of 'isolate'.  See bug 1077872 comment 6, etc.  (Could be others, though.)

Comment 9

[Rik Cabanier]

try build: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f4700ff0a084

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Rik Cabanier from comment #9)
> try build:
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f4700ff0a084

You don't want the nsCSSPropList.h change in https://hg.mozilla.org/try/rev/5212846e4031 .  kIsolationKTable already has an eCSSKeyword_auto entry, and code (e.g., in nsRuleNode.cpp) is set up to expect auto to be an eCSSUnit_Enumerated value rather than an eCSSUnit_Auto value.

Comment 11

[Rik Cabanier]

Attachment: Turn on 'isolation' by default

Sorry. I didn't notice that line was still there.

try build (which includes fix for 1092264):
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ef08bc77c910

Comment 12

[Max Vujovic]

Comment on attachment 8515192 [details] [diff] [review]
Turn on 'isolation' by default

https://hg.mozilla.org/integration/mozilla-inbound/rev/18b705c478a0

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18b705c478a0

Comment 14

[Sebastian Zartner [:sebo]]

Is this worth mentioning in the release notes?

Sebastian

Comment 15

[Jean-Yves Perrier [:teoli]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Activation of a new CSS property
[Suggested wording]: (I will suggest something later)
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/CSS/isolation (still a WIP)

Comment 16

[Jean-Yves Perrier [:teoli]]

Doc created:
https://developer.mozilla.org/en-US/docs/Web/CSS/isolation
and
https://developer.mozilla.org/en-US/Firefox/Releases/36#CSS