1092013 - mozMobileConnection.data.cell is reset to `null` unexpectedly in MobileConnectionService

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Found this by running single marionette test, test_mobile_data_location.js.

Comment 1

[Edgar Chen [:edgar]]

It is a regression of bug 1063304.

Comment 2

[Edgar Chen [:edgar]]

The design of updating function (e.g. _updateConnectionInfo() [1]) is to perform updating *only if* new data is passed. Thus, if no new data is passed into updating function, it should just keep the original data unchanged.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/mobileconnection/gonk/MobileConnectionService.js#481-521

Comment 3

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8514823 [details] [diff] [review]
Patch, v1

Please see comment #2, thank you.

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part 2: Enable ril debug when running mobileConnection tests, v1

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8515577 [details] [diff] [review]
Part 2: Enable ril debug when running mobileConnection tests, v1

Review of attachment 8515577 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi, may I have your review? Thank you.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8514823 [details] [diff] [review]
Patch, v1

Review of attachment 8514823 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you! Please add a comment on the design.

Comment 8

[Edgar Chen [:edgar]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7)
> Comment on attachment 8514823 [details] [diff] [review]
> Patch, v1
> 
> Review of attachment 8514823 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thank you! Please add a comment on the design.

Will do, thank you.

Comment 9

[Edgar Chen [:edgar]]

Attachment: Part 1: mozMobileConnection.data.cell is reset to `null` unexpectedly in MobileConnectionService, v2, r=hsinyi

Add comments about the design of updating function.

Comment 10

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e1a597394db8

Comment 11

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/64db7d36f278
https://hg.mozilla.org/integration/b2g-inbound/rev/566f2111af95

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64db7d36f278
https://hg.mozilla.org/mozilla-central/rev/566f2111af95