1092340 - Remove initializeProfile from automation.py.in

Status: RESOLVED DUPLICATE of bug 1177780

(Testing :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

This method has no consumers:

http://dxr.mozilla.org/mozilla-central/search?q=initializeProfile&case=false

Comment 1

[Harsh]

Can you please paste the repository link?
I have worked with git/github before but never with Hg, I hope commands are almost the same.
Thanks!

Comment 2

[Jonathan Griffin (:jgriffin)]

They're similar, but different.  :)  See https://developer.mozilla.org/en-US/docs/Mercurial for a guide.

Comment 3

[Harsh]

Hi Jonathan, please paste the code repo link. Thanks!

Comment 4

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/mozilla-central/

Note this repo is ~1 GB.

Comment 5

[Harsh]

Attachment: bug-1092340.patch

Comment 6

[Jonathan Griffin (:jgriffin)]

thanks for the patch!  pushed to try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=52cfa71a61c4

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8517875 [details] [diff] [review]
bug-1092340.patch

Review of attachment 8517875 [details] [diff] [review]:
-----------------------------------------------------------------

try looks good!  Can you give this a commit message in the format described at https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#Commit_Message_Conventions ?  I can then land it.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Harsh, can you finish up this patch with a commit message?

When that is uploaded, I would be happy to run it through try server again, and then get it landed

Comment 9

[Harsh]

Hi Jonathan,
Is there a way to add a commit message to an existing patch?

Thanks.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Harsh,

you can take the patch, import it into your queue and push it so it is active.  Then do a 'hg qrefresh -e' and that will take you to an editor where you can out the comment.

A typical comment for this bug would be:
Bug 1092340 - Remove initializeProfile from automation.py.in. r=jgriffin


Also make sure you have your user setup correctly in hg, or edit the patch with 'hg qrefresh -u "Harsh <[e-mail]>"

Of course you can chose the specific name you prefer.

Comment 11

[Melvin Abraham]

Hi, is this bug still being worked on? I'm new and this looks like a good first bug.

Comment 12

[Martijn Wargers (dead)]

Looks like it's already gone.

Comment 13

[Jonathan Griffin (:jgriffin)]

This was just fixed as part of another bug, but thanks for asking!