1092471 - Username capitalised when entering in bank logon screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Matthew Robert McAllum]

User Agent: Mozilla/5.0 (Linux; U; Android 4.4.2; en-nz; GT-P5210 Build/KOT49H) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30

Steps to reproduce:

Goto www.asbbank.co.nz
Tap username
Start entering a lowercase unsername



Actual results:

'mrmcallum' becomes 'Mrmcallum'


Expected results:

'mrmcallum' should have been entered

Comment 1

[Aaron Train [:aaronmt]]

We autocapitalize by default for use in inputs (bug 871884 iirc) for when people write sentences. I believe GeckoInputConnection.java has the logic for auto-capitalizing by default. Re-evaluate?

Comment 2

[Mark Capella [:capella]]

Drive by:

Are we referring in this site:
https://www.dropbox.com/s/chfv96gc1gjxjex/bug1092471.png?dl=0

To the "Enter your access code" field? (ie: "username"?)

I think this may be your keyboard setting ... Google keyboard (and the one I use: SwiftKey) have IME settings for auto-cap at word start.

Google KBD has Settings -> Preferences -> Auto-capitalization
SwiftKey KBD has Settings -> Advanced -> Auto Capitalize

Comment 3

[Wesley Johnston (:wesj)]

The HTML5 way to turn this off is via the "inputmode='verbatim'" attribute on the field. Safari also supports a non-standard "autocapitalize" attribute. I don't see either of those specified here. Do we want to introduce logic to try to guess what behavior the site wants?

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Mark Capella [:capella] from comment #2)
> Drive by:
> 
> Are we referring in this site:
> https://www.dropbox.com/s/chfv96gc1gjxjex/bug1092471.png?dl=0
> 
> To the "Enter your access code" field? (ie: "username"?)
> 
> I think this may be your keyboard setting ... Google keyboard (and the one I
> use: SwiftKey) have IME settings for auto-cap at word start.
> 
> Google KBD has Settings -> Preferences -> Auto-capitalization
> SwiftKey KBD has Settings -> Advanced -> Auto Capitalize

Different form in the mobile version (looks like the desktop site on your tablet).

Comment 5

[Mark Capella [:capella]]

This is the mobile version I see:
https://www.dropbox.com/s/tp1z9519in3puxw/bug1092471Phone.png?dl=0

In the <input> |Access Code|, Auto-capitalization preference as set by the keyboard IME for Google and/or Swift Keyboard dictates the behaviour as I observe it.

Comment 6

[Wesley Johnston (:wesj)]

Lets turn off autocap for input[type="text"] at least. We can leave it on for textfield.

Comment 7

[Matthew Robert McAllum]

It doesn't happen when I use Google Chrome to enter my bank username.

Comment 8

[Mike Hoye [:mhoye]]

This looks like a good first bug if Comment 6 is the accepted approach. Is there consensus there?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mike Hoye [:mhoye] from comment #8)
> This looks like a good first bug if Comment 6 is the accepted approach. Is
> there consensus there?

Sure.

Comment 10

[Mike Hoye [:mhoye]]

Rock and roll.

Comment 11

[Aniket Thakur]

I wish to start working on this bug.

Comment 12

[Mike Hoye [:mhoye]]

Hello, Aniket, and welcome aboard. 

It takes a little bit of work to get set up to build Firefox for Android. You'll be able to get set up by following the instructions here: 

https://wiki.mozilla.org/Mobile/Fennec/Android 

There's a lot there, but don't let that put you off. Once you've got your environment set up, let us know here in the bug, and we'll point you towards the next steps.

Comment 13

[Aniket Thakur]

Hi Mike,

I have already set up fennec build on my local and installed in on my android device. Do guide me with further steps.

Comment 14

[Mike Hoye [:mhoye]]

Hey, awesome! 

OK, the mentor for this bug is Jim Chen. If you have questions for how to proceed, you can ask him via the "need more information" checkbox just below the comments here. For now, let's get you started off in the right place: Jim, can you provide us with a source/DXR link for Aniket?

Comment 15

[Manu Jain]

My suggestion is to make lowercase a default option instead of auto-capitalisation. When a user wants auto-capitalisation he can do it manually as in other browsers.

Comment 16

[Aniket Thakur]

Hi,
    Can I know where is the relevant code where I can get started. Also please confirm if turning off autocap for input[type="text"] is appropriate solution for this.

Comment 17

[Manu Jain]

Attachment: bug1092471.patch

patch created.

Comment 18

[Aniket Thakur]

So this is how it works around here? Someone expresses an interest to solve a bug and wait for appropriate inputs and anyone can come and directly provide a patch. How do beginner level interested candidates get started ? This is just plain sad :(

Comment 19

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Aniket Thakur from comment #18)
> So this is how it works around here? Someone expresses an interest to solve
> a bug and wait for appropriate inputs and anyone can come and directly
> provide a patch. How do beginner level interested candidates get started ?
> This is just plain sad :(

Hi Aniket, sorry about what happened :( Manu is a relatively new contributor just like you, and it looks like both of you were working on this bug at the same time by accident. Usually we avoid conflicts like this by using the "Assigned To" field and set the bug status to "ASSIGNED". For example, if you want to work on this bug, you would assign the bug to yourself (or ask someone to assign the bug to you). This way it's clear to everyone who is working on the bug.

I'm assigning this bug to Manu because he already has a patch, but please find another one here, http://www.joshmatthews.net/bugsahoy/?mobile=1  There are many options and you can pick one that hasn't been assigned yet. Thanks for your understanding!

Comment 20

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8531640 [details] [diff] [review]
bug1092471.patch

Review of attachment 8531640 [details] [diff] [review]:
-----------------------------------------------------------------

Almost there! Can you change it so we use lowercase mode only for "text" fields?

Basically like this:
If mIMETypeHint is "text", set autocapitalized mode if mIMEModeHint is "autocapitalized" (no hyphen).
Otherwise, set autocapitalized mode if mIMEModeHint is not "lowercase"

Comment 21

[Manu Jain]

Sorry Aniket about what has happened. I thought this bug was free as there was no assignee mentioned. It was a misunderstanding.

Comment 22

[Manu Jain]

Attachment: bug_1092471_v2.patch

Changes made as told.

Comment 23

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8531990 [details] [diff] [review]
bug_1092471_v2.patch

Review of attachment 8531990 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, Manu! Thanks! Sorry for the late response.

Comment 24

[(inactive) Jim Chen [:jchen] [:darchons]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad8f115b827d

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/e420c7eb91f6

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e420c7eb91f6

Comment 27

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 37.0a1 (2015-01-11)
Device: Samsung Galaxy S4 (Android 4.4.2)