1093195 - Signature report link from supersearch results doesn't work with a date-limited search

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Liz Henry (:lizzard) (relman/hg->git project)]

From a supersearch result field, such as this one,
https://crash-stats.mozilla.com/search/?signature=%3DMarkInternal%3CJSString%3E&date=%3E%3D10%2F01%2F2014&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

The "Signature report" link doesn't return me results, but instead this message,

date

    Enter a valid date/time.

The signature report link does work if the supersearch wasn't date-limited.

Comment 1

[Peter Bengtsson [:peterbe]]

Hmm... If you enter the date in valid ISO format (https://crash-stats.mozilla.com/search/?signature=%3DMarkInternal%3CJSString%3E&date=%3E%3D2014-10-01&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform) it does NOT help.

Comment 2

[Peter Bengtsson [:peterbe]]

It's reproducible on stage too
https://crash-stats.allizom.org/search/?signature=%3DMarkInternal%3CJSString%3E&date=%3E%3D2014-10-01&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

Comment 3

[Peter Bengtsson [:peterbe]]

The reason I can't reproduce this locally is because locally I have the "Signature report" feature enabled. It means that instead of going to /report/list?... it goes to /signature?... 

This is a feature flag that Adrian appears to NOT have enabled on neither stage or prod. I really don't know why. Do you know Lonnen or Rob?

The fact that the date is parsed incorrectly when going to the fallback (i.e. /report/list) might not be worth doing if all it takes is to enable the new Signature report feature. 

At the time of writing Adrian is on 2 days of PTO. How long can you wait? :)

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Stage has this bad habit of pulling data from our production database every Wednesday, reseting our waffle switches to what prod has. So I need to re-enable that feature every Thursday, and of course I forget. :)

I still think this problem needs to be fixed for the time being. I'm looking into it.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

PR: https://github.com/mozilla/socorro/pull/2466

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0fac96699cc790071b5ba4dc6de2a6b8e5e73c16
Fixes bug 1093195 - Correctly format date for report/list/ in Super Search.

https://github.com/mozilla/socorro/commit/4257be293be995fcc75e99150826635076219d07
Merge pull request #2466 from AdrianGaudebert/1093195-date-report-list

Fixes bug 1093195 - Correctly format date for report/list/ in Super Search.