1093394 - Fix resource dependency issues again in new tablet UI (affects SDK9-only builds)

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Richard Newman [:rnewman]]

Same again. This is mhaigh's file. Throwing it at him unless I fix it first!

 0:13.05 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/new_tablet_tabs_item_cell.xml:24: error: Error: No resource found that matches the given name (at 'textColor' with value '@color/new_tablet_tab_item_title').
 0:13.05
 0:13.05 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/new_tablet_tabs_item_cell.xml:34: error: Error: No resource found that matches the given name (at 'src' with value '@drawable/new_tablet_tab_item_close_button').

Comment 1

[Richard Newman [:rnewman]]

Attachment: Move new_tablet_tabs_item_cell.xml into a tablet resource directory. v1

This makes things build for me.

Comment 2

[Richard Newman [:rnewman]]

Also, I don't even see the color defined at all. Might be a second bug hiding there.

$ ag 'new_tablet_tab_item_title' mobile/
mobile/android/base/resources/layout/new_tablet_tabs_item_cell.xml
30:                  android:textColor="@color/new_tablet_tab_item_title"

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8516370 [details] [diff] [review]
Move new_tablet_tabs_item_cell.xml into a tablet resource directory. v1

Review of attachment 8516370 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

Comment 4

[Martyn Haigh (:mhaigh)]

Tracking that colour issue over at https://bugzilla.mozilla.org/show_bug.cgi?id=1093636

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/6f5199eec3c0

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f5199eec3c0

Comment 7

[Nathan Toone [:toonetown]]

I still get this same build error when building with "MOZ_ANDROID_NEW_TABLET_UI=" unset...except for the error is now complaining about being in the file mobile/android/base/resources/layout-v11/new_tablet_tabs_item_cell.xml

Is it not supported to build Firefox-36 with MOZ_ANDROID_NEW_TABLET_UI unset?

It seems (in my simple test) that moving mobile/android/base/resources/layout-v11/new_tablet_tabs_item_cell.xml to mobile/android/base/newtablet/res/layout-large-v11/new_tablet_tabs_item_cell.xml fixes the issue for when MOZ_ANDROID_NEW_TABLET_UI is not set...though I don't know if that breaks the build when MOZ_ANDROID_NEW_TABLET_UI is set.

Comment 8

[Richard Newman [:rnewman]]

(In reply to Nathan Toone from comment #7)
 
> Is it not supported to build Firefox-36 with MOZ_ANDROID_NEW_TABLET_UI unset?

Correct: it is not supported. The flag will be removed soon.