1093563 - [Flame][v2.1&v2.0][Music]Music time bar operate abnormal when change right-to-left language.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[William Hsu [:whsu]]

Attachment: WP_20141104_009.mp4

+++ This bug was initially created as a clone of Bug #1091455 +++

This a functional defect and reported by our partner.
Please fix it on v2.1.

* Precondition:
 - Select first language in language list
 - Have some songs in phone.

* Steps to reproduce:
  1) Main menu->Play music->Select one song to play->Tap time bar 
  2) Check the time bar display.

* Actual results
 - Time bar operate abnormal when change right-to-left language.
   (Demo video: WP_20141104_009.mp4)

* Expected results:
 - Time bar should operate normally when change right-to-left language.

* Build Information
  @ Tako
   Gaia-Rev    d056733f8a7a1a152f5458b323f092c47dbffa48
   Gecko-Rev   df0479fb8c18379488013452e903c33bca384b0d
   Build ID    20141024145043
   Version     32.0
  @ Flame
   Gaia-Rev    8b0cf889ae0d48a9eb7ecdcb9b67590de45cc5e5
   Gecko-Rev   https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/388b03efe92d
   Build-ID    20141104001202
   Version     34.0
   
* Reproduce Rate ==
  100%

Comment 2

[William Hsu [:whsu]]

[Blocking Requested - why for this release]:

This a functional defect and reported by our partner.
Please fix it on v2.1. Thanks.

Comment 3

[William Hsu [:whsu]]

[Blocking Requested - why for this release]:

Comment 4

[Hema Koka [:hema]]

We are looking into all RTL related issues across all apps in 2.2. Adding this to the music-rtl meta bug.

Thanks
Hema

Comment 5

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

Hey David! Could you review the patch, please?

Let me know if we need to make some changes in the patch.

Thanks!

Comment 6

[David Flanagan [:djf]]

Not a blocker, but will try to review this soon.

Comment 7

[David Flanagan [:djf]]

Comment on attachment 8517370 [details] [review]
Proposed patch

Hub,

Since you're handling RTL compliance for the Music app, I'm passing this review on to you. If you don't think you're familiar enough with that part of the code to review, feel free to send it back to me.

Comment 8

[Hubert Figuiere [:hub]]

Comment on attachment 8517370 [details] [review]
Proposed patch

Looks good to me.

Comment 9

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/984555f287b56a6e4d3ab3878640ac92063c9381

Comment 10

[Elie]

This verified su

Comment 11

[Elie]

Attachment: VIDEO0250_Compress.MP4

This issue verified successfully on Flame 2.2:
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ce27f2692382
Build-ID        20150115002505
Version         37.0a2
Reproduce rate  0/5

Comment 12

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15094/