1093865 - e10s: optgroup w/o a lable attribute prevent select from opening.

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Johnny Stenback (:jst)]

Attachment: foo.html

bug 1080030 broke the money transfer feature on bankofamerica.com if e10s is enabled. The reason is that an optgroup w/o a label attribute causes the select from being populated, so you don't see any options when you try to open the select. I'm attaching a minimized testcase and a fix, but if anyone has ideas on how to add automated tests that would catch this, let me know.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Fix.

Comment 2

[Johnny Stenback (:jst)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c12d13fb6570

Ehsan, I'm guessing this would've been tested had our chrome tests been enabled in e10s builds. Can you look into that? If not, it'd be great if we had a way to test this stuff... Thanks.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c12d13fb6570

Comment 4

[(no longer active)]

(In reply to Johnny Stenback  (:jst, [e-mail]) from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/c12d13fb6570
> 
> Ehsan, I'm guessing this would've been tested had our chrome tests been
> enabled in e10s builds. Can you look into that? If not, it'd be great if we
> had a way to test this stuff... Thanks.

Last I heard about our testing plans (I forget from who) we were hoping to eventually run all of our tests in e10s.  I'm not sure if we have any way of testing something e10s specific in the middle of of our normal test suites.  Brad, do you know who can confirm this, please?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

I'm not sure that I understand your question. We can turn tests on and off in the manifest based on e10s being enabled or not.

Comment 6

[(no longer active)]

Nevermind, seems like the status of e10s testing has improved a lot since the last time I looked.

So I tried to write a test for this, but hit bug 933103 and finally gave up.  As far as I can tell, all of this stuff is completely untested at this point. :/