109389 - Rename the PLEventQueue event receiver window class.

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Wan-Teh Chang]

PLEventQueue (plevent.h, plevent.c) was part of NSPR
before.  I moved it to mozilla/xpcom/threads right
before the NSPR 4.0 release, but I did not change
the contents of the files.  Therefore, the event
receiver window of PLEventQueue is still created
with the window class name "NSPR:EventReceiver".

Several bugs have been filed about the event receiver
window hanging around after the Mozilla client exits.
Because of the "NSPR:EventReceiver" window class name,
these bugs were assigned to the NSPR product and I
had to reassign them to the right product (Browser).
Therefore, I'd like to change the event receiver
window class name to prevent future confusion.  I
propose changing "NSPR" to "PLEventQueue".  I will
attach a patch.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch. Change "NSPR" to "PLEventQueue".

Comment 2

[Wan-Teh Chang]

Comment on attachment 57275 [details] [diff] [review]
Proposed patch.  Change "NSPR" to "PLEventQueue".

Two comments on my patch.

1. An alternative is to change "NSPR" to "XPCOM".  Let me know which one you
prefer: "PLEventQueue" or "XPCOM".

2. I found a DllMain() function in plevent.c, with the
original comment saying "for the NSPR DLL".
I just changed it to say "for the DLL" because I don't know what the DLL name
is.

Comment 3

[Doug Turner (:dougt)]

use XPCOM, instead of PLEventQueue.  The dll's name is XPCOM, but your comment
is also correct.

Comment 4

[Wan-Teh Chang]

Attachment: Proposed patch. Change "NSPR" to "XPCOM".

I incorporated Doug T's suggestion.

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 57673 [details] [diff] [review]
Proposed patch.  Change "NSPR" to "XPCOM".

should have been done when plevents moved to xpcom.

Comment 6

[Alec Flett]

Comment on attachment 57673 [details] [diff] [review]
Proposed patch.  Change "NSPR" to "XPCOM".

sr=alecf

Comment 7

[Wan-Teh Chang]

I checked in the patch, set target milestone to mozilla0.9.7,
and marked the bug fixed.