1094275 - Update the in-tree copy of jemalloc3

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Guilherme Gonçalves [:ggp]]

We need some of the recent changes to jemalloc3 in order to solve the remaining blockers for bug 762449.

Comment 1

[Mike Hommey [:glandium]]

Could you attach the jemalloc 3 update patch here, or at least give the commit sha1 for what the other patches are based on?

Comment 2

[Guilherme Gonçalves [:ggp]]

Attachment: Update the in-tree copy of jemalloc3.

Sure, here it is. I'm on 879e76a9e57 for now.

Comment 3

[Guilherme Gonçalves [:ggp]]

Attachment: Include the WIP bookkeeping patch for jemalloc.

Oh, and here's a patch that imports a slightly outdated version of my bookkeeping patch for
bug 899126. I'm keeping it separate as we'll hopefully get that change upstreamed.

Comment 4

[Mike Hommey [:glandium]]

Can you refresh with current master, which contains the fix for bug 1108045? Then let's start the party by landing this.

Comment 5

[Guilherme Gonçalves [:ggp]]

Attachment: Update the in-tree copy of jemalloc3.

Sure, here it is.

Comment 6

[Guilherme Gonçalves [:ggp]]

Attachment: Patch jemalloc3 so it computes bookkeeping.

And here's the updated bookkeeping patch if you want to include it now too. Feel free to cancel
the review if you don't.

Comment 7

[Guilherme Gonçalves [:ggp]]

Attachment: Update the in-tree copy of jemalloc3.

The previous patch builds on all architectures, but fails static rooting analysis on B2G Desktop Linux x64 [1]. This new version incorporates a patch by :sfink that fixes that [2].

1- https://treeherder.mozilla.org/#/jobs?repo=try&revision=336acb2b8869
2- https://treeherder.mozilla.org/#/jobs?repo=try&revision=55d9754cb127

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8537146 [details] [diff] [review]
Patch jemalloc3 so it computes bookkeeping.

Shouldn't this be in bug 899126?

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 8537339 [details] [diff] [review]
Update the in-tree copy of jemalloc3.

Review of attachment 8537339 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5b1a8e8aee4

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5b1a8e8aee4

Comment 11

[Mike Hommey [:glandium]]

Comment on attachment 8537146 [details] [diff] [review]
Patch jemalloc3 so it computes bookkeeping.

I'll leave a comment about this patch in bug 899126. Sorry it took so long.